Repository navigation
fix: validate product contracts and recover interrupted reads - #2471
Merged
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…d reads Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0e9f6fe0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BReg could accept Action-only client bindings that its verifier would always refuse. Coordinator could accept inaccurate record fakes and computed Messaging template data, omit event starts from explain, and hold interrupted safe reads for an operator.
Closes #2465
Closes #2466
Closes #2467
Closes #2468
Closes #2469
All five findings are worth addressing. #2467 is a small operator-visibility gap and is folded into the behavior fixes. The contract work reuses the existing imports and scenario validators; lease recovery reuses Dispatch's bounded RetryThenHold policy.
The earlier-appointment example demonstrates both imports from adjacent owner projects. Schemas, identifier catalog and CLI catalog are regenerated.
Evidence
Executed checks passed:
Verification limits
The complete native Messaging/Scheduling composition matrix is left to protected CI. The optional Coordinator postgres-test all-targets clippy invocation reports existing type_complexity and await_holding_lock warnings in untouched scheduling_event_native.rs; the changed targets and schema all-targets lint pass.
DCO