Skip to content

fix(release): handle empty macOS component arguments - #2472

Merged
jeremi merged 1 commit into
mainfrom
release/v0.44.0-macos-args
Oct 27, 2026
Merged

jeremi merged 1 commit into
mainfrom
release/v0.44.0-macos-args

Conversation

@jeremi

@jeremi jeremi commented Oct 27, 2026

Copy link
Copy Markdown
Member

Pull Request

Summary

Unblock native macOS candidate builds when there are no optional component arguments. Bash 3.2 treats the empty array as unset under set -u, so the workflow stopped before calling the native builder. Use the guarded array expansion already used by this workflow's wheel assembly, preserving the exact argument list when Discovery is carried forward.

Evidence

  • The executing regression reproduced the failed candidate job under system Bash 3.2 before the fix, then passed with both an empty optional list and --exclude-unit discovery.
  • uv run --with PyYAML==6.0.2 python3 -m unittest release/scripts/test_release_workflow_structure.py: all 92 tests passed. The fixture runs the actual parsed workflow prelude with stubbed build commands and asserts exact arguments and clean output.
  • Actionlint 1.7.12, ShellCheck of the rendered macOS step, system Bash syntax, formatting of the changed build prelude, and diff checks passed. Full-step shfmt reports existing installer indentation outside this change.
  • Release planner: all 13 checks passed. Source-model proof reports a clean checkout. Redacted Gitleaks found no leaks.

Notes

Only the workflow and its owning tests change. Release identity, source binding, build flags, product sources, documentation locks and advisory decisions retain their contracts. A new protected-main candidate must still prove the complete native payload before v0.44.0 publication.

DCO

  • Every commit includes a Signed-off-by trailer.
  • I reviewed the submitted changes and am responsible for the contribution.

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T16:55:56.653743Z e2e71e8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jeremi
jeremi added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit f71bdbc Oct 27, 2026
55 checks passed
@jeremi
jeremi deleted the release/v0.44.0-macos-args branch October 27, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant