Repository navigation
fix(release): handle empty macOS component arguments - #2472
Merged
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Unblock native macOS candidate builds when there are no optional component arguments. Bash 3.2 treats the empty array as unset under
set -u, so the workflow stopped before calling the native builder. Use the guarded array expansion already used by this workflow's wheel assembly, preserving the exact argument list when Discovery is carried forward.Evidence
--exclude-unit discovery.uv run --with PyYAML==6.0.2 python3 -m unittest release/scripts/test_release_workflow_structure.py: all 92 tests passed. The fixture runs the actual parsed workflow prelude with stubbed build commands and asserts exact arguments and clean output.Notes
Only the workflow and its owning tests change. Release identity, source binding, build flags, product sources, documentation locks and advisory decisions retain their contracts. A new protected-main candidate must still prove the complete native payload before v0.44.0 publication.
DCO
Signed-off-bytrailer.