Skip to content

fix(release): select custom roots in the rstack smoke - #2473

Merged
jeremi merged 1 commit into
mainfrom
release/v0.44.0-rstack-smoke
Oct 27, 2026
Merged

jeremi merged 1 commit into
mainfrom
release/v0.44.0-rstack-smoke

Conversation

@jeremi

@jeremi jeremi commented Oct 27, 2026

Copy link
Copy Markdown
Member

Pull Request

Summary

Keep the candidate's rstack install smoke on the generation it just installed. Bootstrap receives custom executable and storage directories, but later commands previously fell back to the runner's home directory. Reuse one explicit-root command array for the launcher version, both installed-component queries, and both product version checks.

Evidence

  • The failed candidate job completed bootstrap before the post-install smoke failed. The executing regression reproduces the first component query's false result without the overrides.
  • The corrected real workflow fragment passes with an isolated home directory and paths containing spaces. It preserves the symlink, single-entry, component and version assertions, and verifies all five exact argument lists with clean output.
  • uv run --with PyYAML==6.0.2 python3 -m unittest release/scripts/test_release_workflow_structure.py: all 93 tests passed.
  • Actionlint 1.7.12, ShellCheck of the full rendered smoke, system Bash syntax, formatting of the new command array, diff checks and redacted Gitleaks passed. Full-step shfmt still reports existing condition, redirection and pipeline formatting outside the new array.
  • Release planner: all 13 checks passed. Source-model proof reports a clean checkout. Independent review found no material blocker.

Notes

The owning CLI and README already require explicit roots on later commands after a custom-path installation. No runtime, product, documentation, image recipe or advisory change is needed. All existing smoke and publication controls remain enforced. A fresh protected-main candidate and matching identifier publisher pin are still required before v0.44.0 publication.

DCO

  • Every commit includes a Signed-off-by trailer.
  • I reviewed the submitted changes and am responsible for the contribution.

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-27T18:38:05.701695Z 213a6b6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jeremi
jeremi added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit bae1899 Oct 27, 2026
55 checks passed
@jeremi
jeremi deleted the release/v0.44.0-rstack-smoke branch October 27, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant