Repository navigation
fix(release): select custom roots in the rstack smoke - #2473
Merged
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Keep the candidate's rstack install smoke on the generation it just installed. Bootstrap receives custom executable and storage directories, but later commands previously fell back to the runner's home directory. Reuse one explicit-root command array for the launcher version, both installed-component queries, and both product version checks.
Evidence
uv run --with PyYAML==6.0.2 python3 -m unittest release/scripts/test_release_workflow_structure.py: all 93 tests passed.Notes
The owning CLI and README already require explicit roots on later commands after a custom-path installation. No runtime, product, documentation, image recipe or advisory change is needed. All existing smoke and publication controls remain enforced. A fresh protected-main candidate and matching identifier publisher pin are still required before v0.44.0 publication.
DCO
Signed-off-bytrailer.