Repository navigation
fix(release): keep Discovery on the Stack train so nightlies build - #2513
Merged
Merged
Conversation
Stack opened 0.45.0 while the Discovery packages stayed at 0.44.0, so every nightly since has stopped on the release identity check. release/OPERATIONS.md keeps Discovery on the Stack train through 1.0. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The nightly channel test hard-coded a 0.44.0 base and assumed every binary reports it, which only held while Discovery's package happened to be 0.44.0. Use the same helper the release path uses. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every nightly since Stack opened 0.45.0 has failed. The Stack packages moved to 0.45.0, but
registry-discoveryandregistry-discoveryctlstayed at 0.44.0, so the build stops at the release identity check:The same mismatch would stop a v0.45.0 candidate.
release/OPERATIONS.mdkeeps Discovery on the Stack train through 1.0, so this moves both packages to 0.45.0. It does not touch the independent-release machinery.Checks run locally:
cargo check --lockedand theversion_clitests for both packagesREGISTRY_NIGHTLY_TAGset to a 0.45.0 nightly tag,discovery --versionanddiscoveryctl --versionreport0.45.0-nightly.<date>.<sha>registry-cli-docstests: the CLI catalog is unchangedrelease/scripts/test_*.pyfiles pass, includingtest_nightly_release.py, whose channel test assumed every binary reports the 0.44.0 base and now uses the release path's own version helperA real nightly run has not been tried; it can only run after merge.