Repository navigation
feat(mcp): add configurable native and adapter providers - #2516
Merged
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
jeremi
marked this pull request as ready for review
October 31, 2026 11:52
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jeremi
marked this pull request as draft
October 31, 2026 11:52
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate the citizen gateway's MCP transport from BReg behavior and add a configurable supporting service with independent provider credentials. Existing BReg deployments keep the released
breg-mcpwrapper; the newregistry-mcpbinary is source-build-only.Behavior
registry-mcp-edge. Preserve the seven citizen tools, target ownership, draft/revision checks, retry identity and browser submission boundary.Source disclosure
An institution may explicitly grant a trusted BReg standing agent
get-review-context, including on submitted Proposals, under an exact requester client and verified actor. This is an independent source service permission. It does not require a task grant or automatically intersect with the represented person's human BReg permissions. The institution must approve the agent profile's disclosure ceiling and reviewer population before enabling it. Submitted mutations and decisions remain refused.The citizen wrapper retains its configuration and audit identity. Its catalog now sorts tool names alphabetically and acquires authorization per binding. Converting to
registry-mcpchanges the configuration envelope and generic audit namespaces; the migration guide explains retained-key and retry requirements.Verification
The final revision CI passed with 52 jobs passed, 11 skipped and zero failures. All 60 executed PR checks passed, including the separate CodeQL findings check; 11 checks were skipped. DCO, Render golden and all three CodeQL language analyses also passed.
The full CI matrix succeeded with 62 jobs passed, 6 skipped and zero failures, including the native staff PostgreSQL lane selected by
ci:full. The final follow-ups correct two setup documents, remove four uncompiled duplicate modules, and keep unit-test assertion failure messages value-free. It uses normal protected CI; compiled runtime code is unchanged from that full-matrix proof. The 267 affected MCP package tests passed again after removal. Adapter native tests additionally require a separately built matching producer and owned database; the committed golden compatibility check runs without that producer.Availability and limits
registry-mcpis not a release asset, installer component or image. The Adapter binding remains experimental while its compatible producer is separate work; integration order remains Adapter first, then MCP after matching proof.dataClass: non-personalis an unchecked operator attestation, and the positive external fixtures use facility data. External personal delegation and writes are outside this increment.The Adapter prototype reads a machine token once at startup; automatic short-lived credential acquisition/renewal is deferred and token expiry requires replacement/restart. Native drills use synthetic issuers and sources; they do not establish stock or institutional issuer compatibility. No merge, release or deployment is performed by this PR.