Repository navigation
fix: preserve Proposal JSON and bound BReg metadata separately - #2523
Merged
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add exact JSON Proposal preparation and listing methods to the Node client, preserving native JSON values and opaque authority identifiers. Accept valid bounded vocabulary codes such as
A-reportwhen selecting advertised Actions.Give Coordinator Action and Proposal metadata reads a finite 8 MiB ceiling while retaining the 64 KiB business-response limit. Oversized reads and preparation fail terminally; oversized mutation responses retain their uncertain outcome and existing recovery requirements. Existing downstream authority and current-source checks remain in force.
Validation on the committed source bytes:
The broader vocabulary fixtures establish SDK decoding, not native immediate-Action compiler acceptance. These are local development-candidate results; hosted CI and release acceptance are separate. Security-sensitive behavior and limits are described in the updated Coordinator security-review notes.