Repository navigation
feat(coordinator): declare the expected choose case for readers - #2537
Merged
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
jeremi
marked this pull request as ready for review
November 1, 2026 12:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
jeremi
enabled auto-merge
November 1, 2026 12:21
jeremi
disabled auto-merge
November 1, 2026 12:25
jeremi
enabled auto-merge
November 1, 2026 12:25
jeremi
disabled auto-merge
November 1, 2026 12:53
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A choose step can now declare optional
expected: <case-label>so readers and diagram tools can identify its everyday path. Check validates the label against that step's cases, and JSONcheck --explainexposes it on the step. Both compare and mapped-string choices are supported.The hint lives in presentation metadata, survives snapshots, and leaves routing,
nextordering, andworkflowRevisionunchanged. The change includes the generated schema and catalog hashes, documentation, and regression coverage. It also corrects a schema-test expectation that omitted the already-supported compare mapping.Schema-enabled checking now shares declared-refusal schema derivation with the catalog generator. This fixes two failures reproduced on baseline main: schema-mode lookup validation now enforces the catalog's existing
unresolvedconstraint. Generated bytes and ordinary-build behavior are unchanged. An all-operation parity test prevents the in-memory and generated refusal contracts from diverging again.Validation:
Local PostgreSQL/native-service suites were not run; the PR's selected hosted CI jobs cover those boundaries.
Closes #2536.