Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/release-canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ jobs:
encoding="utf-8",
)
PY
python3 release/scripts/rstack_components.py --version "${version}" \
< canary/payloads.json > canary/components.json
for name in "${image_names[@]}"; do
jq -n \
--arg name "${name}" \
Expand Down Expand Up @@ -199,6 +201,7 @@ jobs:
--slurpfile payloads canary/payloads.json \
--slurpfile images canary/images.json \
--slurpfile scans canary/scans.json \
--slurpfile components canary/components.json \
'{
schema_version: "registry-stack.release-candidate.v2",
repository: $repository,
Expand Down Expand Up @@ -238,7 +241,8 @@ jobs:
name: ("registry-stack-" + $tag + "-candidate.tar.gz"),
size: $bundle_size,
sha256: $bundle_sha
}
},
components: $components[0]
}' > canary/candidate-manifest.draft.json
python3 release/scripts/release_candidate.py seal-candidate \
--draft canary/candidate-manifest.draft.json \
Expand Down
24 changes: 24 additions & 0 deletions release/scripts/test_release_workflow_structure.py
Original file line number Diff line number Diff line change
Expand Up @@ -3375,6 +3375,30 @@ def test_canary_is_async_and_has_no_public_write_permission(self) -> None:
self.assertIn("docs: {", text)
self.assertNotIn("docs-dispatch", text)

def test_canary_manifest_carries_components_from_the_first_rstack_release(
self,
) -> None:
# The candidate validator requires `components` on every stack
# candidate at or after the first rstack release, so a canary
# version past that release must build the member the same way
# release-candidate.yml does.
_, document = workflow("release-canary.yml")
script = "\n".join(
step.get("run", "")
for job in document["jobs"].values()
for step in job.get("steps", [])
)
version = re.search(r"^version=(\d+)\.(\d+)\.(\d+)$", script, re.M)
self.assertIsNotNone(version)
canary_version = tuple(int(part) for part in version.groups())
self.assertIsNotNone(release_roster.RSTACK_FIRST_RELEASE)
self.assertGreaterEqual(canary_version, release_roster.RSTACK_FIRST_RELEASE)
self.assertIn(
'python3 release/scripts/rstack_components.py --version "${version}"',
script,
)
self.assertIn("components: $components[0]", script)

def test_scorecard_is_schedule_or_manual_only(self) -> None:
text, _ = workflow("scorecard.yml")
trigger = text.split("permissions:", 1)[0]
Expand Down
Loading