Code blocks rendered as <pre><code></code></pre>

[verhovsky]

I don't like that code blocks are rendered into

<pre>
  <code class="language-python">
  </code>
</pre>

It should just be

<pre class="language-python">
</pre>

kind of like it is on GitHub. <code> is for inline code.

[ChristianMurphy]

This project follows CommonMark.
CommonMark includes code https://spec.commonmark.org/0.31.2/#fenced-code-blocks
Github also includes the code tag, it follows GFM which is CommonMark based.

If you dislike how a node is translated and want to diverge from CommonMark, use the handlers option https://github.com/remarkjs/remark-rehype?tab=readme-ov-file#options
And customize the output to anything you'd like

[github-actions]

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

[verhovsky]

Github doesn't include the code tag

[remcohaszing]

I was sure GitHub used <pre><code> as well, but I see you’re right, they don’t now. They do on the https://docs.github.com though. Also MDN recommends this. But most importantly, we follow CommonMark.

As @ChristianMurphy mentioned, you can use a custom handler. Alternatively you can transform the hast with a custom rehype plugin.

[ChristianMurphy]

Adding on.

Github flavored markdown does include code https://github.github.com/gfm/#fenced-code-blocks

Github.com sometimes breaks with their own standard. 🤷‍♂️

[wooorm]

Yep, it’s at https://github.com/github/cmark-gfm/blob/587a12bb54d95ac37241377e6ddc93ea0e45439b/src/cmark-gfm.h#L744-L747!

Maybe of interest, they do more things with that. You can write it with HTML too. So a markdown file:

<pre lang="javascript">console.log(1)</pre>

Turns into:

console.log(1)

[verhovsky]

In other words there's GitHub Flavoured Markdown Flavoured Markdown and (with the right settings) GitHub Flavoured GitHub Flavoured Markdown