Skip to content

Commit 5dc12ea

Browse files
feat: add Vite 8 support (#14876)
1 parent 000846c commit 5dc12ea

103 files changed

Lines changed: 3679 additions & 1109 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.changeset/support-vite-8.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@react-router/dev": minor
3+
---
4+
5+
Add support for Vite 8

.github/workflows/integration-full.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
uses: ./.github/workflows/shared-integration.yml
3232
with:
3333
os: "ubuntu-latest"
34-
node_version: "[20.18, 22]"
34+
node_version: "[20.19, 22]"
3535
browser: '["chromium", "firefox"]'
3636

3737
integration-windows:
@@ -50,5 +50,5 @@ jobs:
5050
uses: ./.github/workflows/shared-integration.yml
5151
with:
5252
os: "macos-latest"
53-
node_version: "[20.18, 22]"
53+
node_version: "[20.19, 22]"
5454
browser: '["webkit"]'

.github/workflows/integration-pr-windows-macos.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: PR (Full)
22

33
# PRs touching @react-router/dev will also run on Ubuntu/Firefox, Windows/Edge and
4-
# OSX/WebKit as well as an Ubuntu/Chromium run on Node 20.18.
4+
# OSX/WebKit as well as an Ubuntu/Chromium run on Node 20.19.
55

66
on:
77
pull_request:
@@ -22,7 +22,7 @@ jobs:
2222
uses: ./.github/workflows/shared-integration.yml
2323
with:
2424
os: "ubuntu-latest"
25-
node_version: "[20.18]"
25+
node_version: "[20.19]"
2626
browser: '["chromium"]'
2727

2828
integration-firefox:

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
fail-fast: false
2727
matrix:
2828
node:
29-
- 20.18
29+
- 20.19
3030
- 22
3131

3232
runs-on: ubuntu-latest

integration/client-data-test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,7 @@ test.describe("Client Data", () => {
606606
}
607607
`,
608608
"app/routes/client-loader-critical.bubbled-server-loader-errors-are-persisted-for-hydrating-routes.parent.child.tsx": js`
609-
import { useRouteError, useLoaderData } from 'react-router'
609+
import { useLoaderData } from 'react-router'
610610
export function loader() {
611611
throw new Error('Child Server Error');
612612
}

integration/helpers/create-fixture.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -509,9 +509,6 @@ function reactRouterBuild(
509509
env: {
510510
...process.env,
511511
NODE_ENV: mode || ServerMode.Production,
512-
// Ensure build can pass in Rolldown. This can be removed once
513-
// "preserveEntrySignatures" is supported in rolldown-vite.
514-
ROLLDOWN_OPTIONS_VALIDATION: "loose",
515512
},
516513
});
517514

integration/helpers/rsc-vite-framework/package.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,13 @@
1919
"@types/react": "catalog:react-canary",
2020
"@types/react-dom": "catalog:react-canary",
2121
"@vanilla-extract/css": "^1.17.4",
22-
"@vanilla-extract/vite-plugin": "^5.1.1",
23-
"@vitejs/plugin-react": "^4.5.2",
22+
"@vanilla-extract/vite-plugin": "^5.2.0",
23+
"@vitejs/plugin-react": "^6.0.1",
2424
"@vitejs/plugin-rsc": "catalog:",
2525
"cross-env": "^7.0.3",
2626
"typescript": "catalog:",
27-
"vite": "^6.3.0",
28-
"vite-env-only": "^3.0.1",
29-
"vite-tsconfig-paths": "^4.2.1"
27+
"vite": "^8.0.0",
28+
"vite-env-only": "^3.0.1"
3029
},
3130
"dependencies": {
3231
"@mjackson/node-fetch-server": "0.6.1",

integration/helpers/templates.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const templates = [
33
{ name: "vite-5-template", displayName: "Vite 5" },
44
{ name: "vite-6-template", displayName: "Vite 6" },
55
{ name: "vite-7-beta-template", displayName: "Vite 7 Beta" },
6-
{ name: "vite-rolldown-template", displayName: "Vite Rolldown" },
6+
{ name: "vite-8-template", displayName: "Vite 8" },
77

88
// RSC templates
99
{ name: "rsc-vite", displayName: "RSC (Vite)" },
@@ -25,5 +25,5 @@ export const viteMajorTemplates = getTemplates([
2525
"vite-5-template",
2626
"vite-6-template",
2727
"vite-7-beta-template",
28-
"vite-rolldown-template",
28+
"vite-8-template",
2929
]);
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)