Add data route matcher abstraction - #15297
Merged
Merged
Conversation
Contributor
Preview Build AvailablePreview builds have been created for this PR. You can install pnpm install "remix-run/react-router#preview/pr-15297&path:packages/react-router"And/or install other packages via: pnpm install "remix-run/react-router#preview/pr-15297&path:packages/react-router-dev"
pnpm install "remix-run/react-router#preview/pr-15297&path:packages/react-router-express"
pnpm install "remix-run/react-router#preview/pr-15297&path:packages/react-router-node"
pnpm install "remix-run/react-router#preview/pr-15297&path:packages/react-router-serve"These preview builds will be updated automatically as you push new commits. |
brophdawg11
force-pushed
the
brophdawg11/codex-data-route-matcher
branch
2 times, most recently
from
August 6, 2026 20:14
d6a4232 to
dd294db
Compare
brophdawg11
marked this pull request as ready for review
August 6, 2026 20:14
brophdawg11
force-pushed
the
brophdawg11/codex-data-route-matcher
branch
from
August 7, 2026 13:44
b022639 to
57834ce
Compare
Contributor
✅ CLA SignedThanks for signing the Contributor License Agreement. |
Contributor
✅ Change File FoundOne or more change files found.
|
brophdawg11
force-pushed
the
brophdawg11/codex-data-route-matcher
branch
3 times, most recently
from
August 20, 2026 14:32
daef0f0 to
ba94ff6
Compare
Assisted-By: devx/755516d2-c45b-45bf-b52b-d964afb579bb
Assisted-By: devx/755516d2-c45b-45bf-b52b-d964afb579bb
Assisted-By: devx/755516d2-c45b-45bf-b52b-d964afb579bb
Assisted-By: devx/755516d2-c45b-45bf-b52b-d964afb579bb
Assisted-By: devx/597728f0-1b3f-4153-b929-18dbff6cd683
Assisted-By: devx/597728f0-1b3f-4153-b929-18dbff6cd683
brophdawg11
force-pushed
the
brophdawg11/codex-data-route-matcher
branch
from
August 20, 2026 18:04
ba94ff6 to
b1609dc
Compare
Assisted-By: devx/b2552a8f-d5a9-42ae-99b3-bb72dd06a325
Assisted-By: devx/b2552a8f-d5a9-42ae-99b3-bb72dd06a325
…a-route-matcher # Conflicts: # packages/react-router/lib/components.tsx # packages/react-router/lib/dom/server.tsx # packages/react-router/lib/router/router.ts
Contributor
|
The preview branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a
DataRouteMatcherabstraction for data routers while keeping the existing v6 regex route matching behavior as the only implementation.It keeps route flattening and matching state together so later matching implementations can plug into the same router call sites without changing current behavior.