fix: pass --conditions as argv when relaunching the dev CLI

[official-burak]

Fixes #15433

Changelog

react-router dev relaunches itself with --conditions=development so the package imports map resolves the development build. Since 8.3.0 that relaunch put the flag in NODE_OPTIONS. Node honors that. Bun does not: it keeps the env var but never applies --conditions, so #development-condition-enabled stays false, dev() restarts a second time, and the already-restarted guard throws.

Description

Pass the extra flags on argv immediately after the runtime binary (node --conditions=development … / bun --conditions=development …) and stop writing them into NODE_OPTIONS. Existing NODE_OPTIONS from the user are still inherited. The already-restarted guard is unchanged.

Test evidence

Fail-then-pass on packages/react-router-dev/__tests__/restart-with-conditions-test.ts:

• before: spawn args had no --conditions flag; it was merged into NODE_OPTIONS
• after: --conditions=development is args[0]; caller NODE_OPTIONS is left alone

pnpm test packages/react-router-dev/: 10 suites, 190 tests passed.

Local Bun check matching the issue: NODE_OPTIONS=--conditions=development bun --bun leaves the flag in the environment but not in process.execArgv. bun --bun --conditions=development puts it on execArgv.

[official-burak]

Pushed 95f74b5 for the Chromium failure on cli › dev restarts with the development condition and starts the server.

waitForDevServer already succeeded. restartCount still matched Relaunching with NODE_OPTIONS:, while the relaunch line is now Relaunching with --conditions=development, so the count stayed at 0. The matcher now keys off Relaunching with .