Prevent streaming disconnects from crashing Node - #15437
Merged
Merged
Conversation
(cherry picked from commit 1401852) Assisted-By: devx/58de020f-a53b-4434-bdad-a50684884b0a
Contributor
Preview Build AvailablePreview builds have been created for this PR. You can install pnpm install "remix-run/react-router#preview/pr-15437&path:packages/react-router"And/or install other packages via: pnpm install "remix-run/react-router#preview/pr-15437&path:packages/react-router-dev"
pnpm install "remix-run/react-router#preview/pr-15437&path:packages/react-router-express"
pnpm install "remix-run/react-router#preview/pr-15437&path:packages/react-router-node"
pnpm install "remix-run/react-router#preview/pr-15437&path:packages/react-router-serve"These preview builds will be updated automatically as you push new commits. |
Merged
Contributor
|
The preview branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #15324 to
v7.What does this change?
Prevents
@react-router/nodestreaming disconnects from crashing the Node process when a destination writable closes or is destroyed while a readable stream is active.Benign writable closures cancel upstream reads without propagating a synthetic error, while genuine stream failures continue to preserve their error behavior. Cleanup also handles writable errors that are already pending.
Testing
pnpm test packages/react-router-node/__tests__/stream-test.tspnpm run --filter react-router buildpnpm run --filter @react-router/node typecheck