Skip to content

fix: preserve SPA lazy route errors - #15464

Open
copacabanaservice01 wants to merge 1 commit into
remix-run:mainfrom
copacabanaservice01:fix/preserve-spa-lazy-route-errors
Open

fix: preserve SPA lazy route errors#15464
copacabanaservice01 wants to merge 1 commit into
remix-run:mainfrom
copacabanaservice01:fix/preserve-spa-lazy-route-errors

Conversation

@copacabanaservice01

Copy link
Copy Markdown

Summary

  • preserve the DataStrategyResult returned by match.resolve() in the non-SSR single-fetch strategy
  • allow lazy route module import failures to reach the route error boundary instead of becoming a missing-result error
  • add regression coverage and a patch change note

Test plan

  • pnpm test packages/react-router/__tests__/router/data-strategy-test.ts --runInBand (27 passed)
  • pnpm run --filter react-router typecheck
  • pnpm run --filter react-router build
  • Prettier and ESLint on the touched TypeScript files
  • pnpm run changes:validate

Notes

The broader packages/react-router/ suite passed 113/114 suites locally. The remaining special-characters-test.tsx failures are reproducible on an unmodified origin/main worktree under Windows (10 baseline failures versus 8 on this branch).

Closes #15459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ssr: false — a failed lazy route-module import is swallowed and surfaces as "No result returned from dataStrategy for route X"

1 participant