Repository navigation
feat(workflow): add sentinel stall guard and telemetry - #17
Merged
Merged
Conversation
Add optional Sentinel workflow config and per-step stall policies to detect stalls, record telemetry, and abort or mark steps deterministically. Includes docs and tests.
proc.kill() sends SIGTERM which may not terminate child processes spawned via 'sh -c ...', leaving pipes open and blocking stream reads indefinitely. Use SIGKILL (signal 9) to guarantee immediate process termination.
Use process.kill(-pid, SIGKILL) to terminate the entire process group, ensuring child processes spawned by the shell are also killed. Falls back to proc.kill(9) if process group kill fails.
Instead of relying solely on proc.kill() to close pipes (which may fail when shell child processes keep pipes open), race the probe work against a timeout promise. This guarantees run() returns within timeoutMs regardless of process cleanup behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add optional Sentinel support to workflow execution:
sentinelconfig + step-levelstallpolicy (parser + types)Why
Detect and handle stalled steps deterministically (especially around long-running agents) and persist enough telemetry to debug/iterate on policies.
Notes
docs/features/and new unit/AT coverage undertests/.Testing
Not run in this environment.