Skip to content

feat(workflow): resolve management agent review findings - #19

Merged
reoring merged 2 commits into
feat/workflow-agentfrom
roboppi/loop-20260227-121443
Mar 1, 2026
Merged

reoring merged 2 commits into
feat/workflow-agentfrom
roboppi/loop-20260227-121443

Conversation

@reoring

@reoring reoring commented Mar 1, 2026

Copy link
Copy Markdown
Owner

What

Close out the findings in docs/features/workflow-management-agent-implementation-review.md and add a self-dev loop workflow that can repeatedly implement/test/review until COMPLETE.

Changes

  • Isolate management worker events from the main sink/TUI; write management worker events to per-invocation JSONL.
  • Unify management directive shape validation across engines and enforce step-state constraints.
  • Wire pre_check hook and add check overlays/timeout overrides.
  • Resolve management.agent.agent via agent catalog; support step-level per-hook overrides.
  • Persist management abort reason in workflow metadata; record engine meta (reasoning/confidence) in decisions log.
  • Keep PiSdkEngine read-only (policy/mechanism separation).
  • Add variant passthrough for OPENCODE (used to run gpt-5.2 completion reviews with xhigh/high).
  • Improve CLAUDE_CODE streaming (use stream-json in STREAM mode, with required flags).
  • Add examples/workflow-management-agent-impl-review-loop.yaml + bootstrap script; ignore context/ artifacts.

Verification

  • make test-all

Notes

  • The PR contains two commits: core implementation + self-dev loop workflow.

reoring added 2 commits March 1, 2026 10:42
Harden management hooks (event isolation, directive validation, pre_check wiring, catalog resolution) and improve worker adapters for self-dev loop; update docs and tests to match.
Add a Roboppi workflow that TODO-izes the management-agent implementation review and loops implement/test/review until COMPLETE; ignore local context artifacts.
@reoring
reoring merged commit 5554693 into feat/workflow-agent Mar 1, 2026
2 checks passed
@reoring
reoring deleted the roboppi/loop-20260227-121443 branch March 1, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant