fix(redactors): move redactor storage from ConfigMaps to Secrets - #6033
Merged
Conversation
|
Reviews (1): Last reviewed commit: "fix(redactors): move rendered redactor s..." | Re-trigger Greptile |
|
Reviews (2): Last reviewed commit: "fix(redactors): move kotsadm-redact back..." | Re-trigger Greptile |
Member
Author
|
Before: After: |
Member
Author
|
making this draft - not worth the risk, folks shouldn't be putting sensitive info in a redactor anyway |
xavpaice
marked this pull request as draft
August 21, 2026 00:51
divolgin
approved these changes
Aug 21, 2026
xavpaice
marked this pull request as ready for review
August 23, 2026 20:45
|
Reviews (3): Last reviewed commit: "fix(redactors): move kotsadm-redact back..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Moves all redactor storage from Kubernetes ConfigMaps to Secrets. The default
clusterResourcescollector includes all ConfigMap data in support bundles in clear text, so redactor definitions that contain literal values (e.g., value-based redactors) were leaking sensitive data into support bundles. Storing redactors in Secrets removes them from that clear-text collection path and protects them with Kubernetes RBAC.Specifically:
github.com/replicatedhq/troubleshoottov0.133.0, which addssecret/...redactor URI support.kotsadm-redactbackend store from a ConfigMap to a Secret.kotsadm-redact-spec,kotsadm-<slug>-redact-spec,kotsadm-redact-default-spec) from ConfigMaps to Secrets.kotsadm-redactbackend and delete legacy rendered redactor ConfigMaps.Which issue(s) this PR fixes:
Fixes https://app.shortcut.com/replicated/story/139291/security-move-redactor-specs-from-configmaps-to-secrets
Does this PR require a test?
Existing tests were updated and new tests were added in:
pkg/redact/redact_test.gopkg/redact/default_test.gopkg/supportbundle/migrate_test.goDoes this PR require a release note?
New features:
Bug fixes:
Improvements:
Does this PR require documentation?
NONE