fix(snapshots): detect kURL minio add-on from any repository - #6037
Merged
Conversation
|
Reviews (1): Last reviewed commit: "fix(snapshots): detect kURL minio add-on..." | Re-trigger Greptile |
GetMinioImage only recognized the add-on when its image came from minio/minio, so the kurlsh/minio image kURL now ships returned "". That made IsFileSystemMinioDisabled report minio as disabled, which put NFS/host path snapshots into LVP mode and hid both destinations from the Admin Console unless the local-volume-provider plugin was installed. Match on the image name and RELEASE tag instead of the registry and organization. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
sgalsaleh
force-pushed
the
fix-minio-image-match-any-repo
branch
from
August 21, 2026 18:14
e44fc1a to
2ea7f96
Compare
|
Reviews (2): Last reviewed commit: "fix(snapshots): detect kURL minio add-on..." | Re-trigger Greptile |
banjoh
previously approved these changes
Aug 24, 2026
|
Reviews (3): Last reviewed commit: "fix(snapshots): don't decide minio avail..." | Re-trigger Greptile |
sgalsaleh
force-pushed
the
fix-minio-image-match-any-repo
branch
from
August 24, 2026 16:54
17cfff0 to
2ea7f96
Compare
|
Reviews (4): Last reviewed commit: "fix(snapshots): detect kURL minio add-on..." | Re-trigger Greptile |
banjoh
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetMinioImageonly recognized the kURL minio add-on when its image came fromminio/minio, so thekurlsh/minioimage kURL now ships returned"". That madeIsFileSystemMinioDisabledreport minio as disabled, putting NFS/host path snapshots into LVP mode and hiding both destinations from the Admin Console snapshot settings unless thelocal-volume-providerplugin was installed.Now matches on the image name and
RELEASEtag instead of the registry and organization, sominio/minio:RELEASE.…,kurlsh/minio:RELEASE.…and registry-prefixed variants all resolve. Non-RELEASEtags still return""as before.Tests added for the kurlsh repo, a private-registry prefix, and a non-
RELEASEtag.🤖 Generated with Claude Code