Skip to content

fix(supportbundle): include default redactor spec in support bundle command - #6040

Merged
xavpaice merged 1 commit into
mainfrom
sc-139424/include-default-redactor-in-support-bundle-command
Aug 31, 2026
Merged

fix(supportbundle): include default redactor spec in support bundle command#6040
xavpaice merged 1 commit into
mainfrom
sc-139424/include-default-redactor-in-support-bundle-command

Conversation

@xavpaice

@xavpaice xavpaice commented Aug 30, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

The support bundle command API (GetSupportBundleCommand) was generating a kubectl support-bundle command that omitted the default redactor spec. The in-cluster collection path already includes this default redactor via CreateSupportBundleDependencies, so the CLI command was inconsistent and could expose IP addresses that should be redacted by default. This PR adds the default redactor URI to the generated command so both paths apply the same redactors.

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/139424

Does this PR require a test?

Yes, a unit test was added in pkg/supportbundle/supportbundle_test.go to verify the generated command includes the default redactor spec.

Does this PR require a release note?

Bug fixes:


Fixed an issue where the support bundle command returned by the KOTS admin console did not include the default redactor spec, causing IP addresses to not be redacted when the command was run outside of the cluster.

Does this PR require documentation?

NONE

@greptile-apps

greptile-apps Bot commented Aug 30, 2026

Copy link
Copy Markdown

Reviews (1): Last reviewed commit: "fix(supportbundle): include default reda..." | Re-trigger Greptile

@xavpaice
xavpaice merged commit 73f89f5 into main Aug 31, 2026
177 of 180 checks passed
@xavpaice
xavpaice deleted the sc-139424/include-default-redactor-in-support-bundle-command branch August 31, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants