fix(supportbundle): include default redactor spec in support bundle command - #6040
Merged
xavpaice merged 1 commit intoAug 31, 2026
Merged
Conversation
|
Reviews (1): Last reviewed commit: "fix(supportbundle): include default reda..." | Re-trigger Greptile |
sgalsaleh
approved these changes
Aug 31, 2026
xavpaice
deleted the
sc-139424/include-default-redactor-in-support-bundle-command
branch
August 31, 2026 01:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The support bundle command API (
GetSupportBundleCommand) was generating akubectl support-bundlecommand that omitted the default redactor spec. The in-cluster collection path already includes this default redactor viaCreateSupportBundleDependencies, so the CLI command was inconsistent and could expose IP addresses that should be redacted by default. This PR adds the default redactor URI to the generated command so both paths apply the same redactors.Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/139424
Does this PR require a test?
Yes, a unit test was added in
pkg/supportbundle/supportbundle_test.goto verify the generated command includes the default redactor spec.Does this PR require a release note?
Bug fixes:
Does this PR require documentation?
NONE