chore(deps): upgrade troubleshoot to v0.134.0 and k8s libs to 1.37 - #6047
Merged
Conversation
troubleshoot v0.134.0 carries three support bundle redaction fixes: connection strings without a trailing database name, credentials in mysql DSNs over tcp4/tcp6/unix, and an expanded env-name list covering api_key, secret, auth, private_key and credential. It requires the k8s 0.37 staging modules, which need k8s.io/kubernetes and k8s.io/component-helpers raised to match: both are indirect, so nothing in the graph was pulling them up, leaving 0.36 kubelet and component-helpers code compiling against 0.37 API types. Raise both, retarget the existing staging replace block, and move kubectl and cluster-bootstrap so the tree is not split across two k8s lines. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Reviews (1): Last reviewed commit: "chore(deps): upgrade troubleshoot to v0...." | Re-trigger Greptile |
dydx
approved these changes
Sep 4, 2026
dydx
left a comment
dydx
left a comment
Member
There was a problem hiding this comment.
I see 90 checks passing and greptile not complaining. I think this is likely OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Picks up troubleshoot v0.134.0 for three support bundle redaction fixes: connection strings with no trailing database name (
postgres://user:pass@host:5432), mysql DSNs over tcp4/tcp6/unix, and an expanded credential env-name list (api_key,secret,private_key, …). All three affect KOTS-generated bundles.It requires the k8s 0.37 staging modules, so
k8s.io/kubernetesandk8s.io/component-helpers— both indirect, nothing was raising them — move to match, along with the existing stagingreplaceblock,kubectlandcluster-bootstrap. No new replace directives; go.sum net shrinks.Which issue(s) this PR fixes:
Ships sc-139337 into KOTS.
Does this PR require a test?
NONE — covered by tests in troubleshoot. Locally
go build ./...andgo mod tidyare clean andpkg/redact,pkg/supportbundle,pkg/preflight,pkg/kotsutil,pkg/base,pkg/operator/...,pkg/handlerspass. Reviewers should weigh the client-go 1.37 move on runtime behaviour, which compilation doesn't cover — CI and e2e are the real gate.Does this PR require a release note?
New features:
Bug fixes:
Improvements:
Does this PR require documentation?
NONE
🤖 Generated with Claude Code