fix: resolve linting errors for CI

- Remove unnecessary nil check in host_kernel_configs.go (len() for nil slices is zero)
- Remove unnecessary fmt.Sprintf() calls in ceph.go for static strings
- Apply go fmt formatting fixes

Fixes failing lint CI check

Author: bennyyang11

cmd/analyze/cli/root.go

@@ -16,8 +16,8 @@ import (
 // validateArgs allows certain flags to run without requiring bundle arguments
 func validateArgs(cmd *cobra.Command, args []string) error {
 	// Special flags that don't require bundle arguments
-	if cmd.Flags().Changed("check-ollama") || cmd.Flags().Changed("setup-ollama") || 
-	   cmd.Flags().Changed("list-models") || cmd.Flags().Changed("pull-model") {
+	if cmd.Flags().Changed("check-ollama") || cmd.Flags().Changed("setup-ollama") ||
+		cmd.Flags().Changed("list-models") || cmd.Flags().Changed("pull-model") {
 		return nil
 	}
 

cmd/analyze/cli/run.go

@@ -35,11 +35,11 @@ func runAnalyzers(v *viper.Viper, bundlePath string) error {
 	if v.GetBool("check-ollama") {
 		return handleOllamaStatus(v)
 	}
-	
+
 	if v.GetBool("list-models") {
 		return handleListModels(v)
 	}
-	
+
 	if v.GetBool("pull-model") {
 		return handlePullModel(v)
 	}
@@ -50,11 +50,11 @@ func runAnalyzers(v *viper.Viper, bundlePath string) error {
 	}
 
 	// Check if advanced analysis is requested
-	useAdvanced := v.GetBool("advanced-analysis") || 
-		v.GetBool("enable-ollama") || 
-		v.GetBool("disable-ollama") ||  // ← FIX: disable-ollama should still use advanced engine
-		(len(v.GetStringSlice("agents")) > 1 || 
-		 (len(v.GetStringSlice("agents")) == 1 && v.GetStringSlice("agents")[0] != "local"))
+	useAdvanced := v.GetBool("advanced-analysis") ||
+		v.GetBool("enable-ollama") ||
+		v.GetBool("disable-ollama") || // ← FIX: disable-ollama should still use advanced engine
+		(len(v.GetStringSlice("agents")) > 1 ||
+			(len(v.GetStringSlice("agents")) == 1 && v.GetStringSlice("agents")[0] != "local"))
 
 	if useAdvanced {
 		return runAdvancedAnalysis(v, bundlePath)
@@ -485,7 +485,7 @@ func loadSupportBundle(bundlePath string) (*analyzer.SupportBundle, error) {
 
 	// Create bundle structure
 	bundle := &analyzer.SupportBundle{
-		Files:    make(map[string][]byte),
+		Files: make(map[string][]byte),
 		Metadata: &analyzer.SupportBundleMetadata{
 			CreatedAt:   time.Now(),
 			Version:     "1.0.0",
@@ -526,7 +526,7 @@ func loadSupportBundle(bundlePath string) (*analyzer.SupportBundle, error) {
 	}
 
 	klog.Infof("Successfully loaded support bundle with %d files", len(bundle.Files))
-	
+
 	return bundle, nil
 }
 

pkg/analyze/agents/ollama/ollama_agent.go

@@ -714,29 +714,29 @@ func (a *OllamaAgent) autoDetectFileForAnalyzer(bundle *analyzer.SupportBundle,
 				}
 			}
 		}
-		
+
 	case "crd", "customResourceDefinition":
 		// CRD analyzers - look for custom resource files
 		if traditionalAnalyzer, ok := spec.Config["analyzer"]; ok {
 			if crdAnalyzer, ok := traditionalAnalyzer.(*troubleshootv1beta2.CustomResourceDefinition); ok {
 				// Look for specific CRD name in custom-resources directory
 				crdName := crdAnalyzer.CustomResourceDefinitionName
 				for path, data := range bundle.Files {
-					if strings.Contains(path, "custom-resources") && 
-					   (strings.Contains(strings.ToLower(path), strings.ToLower(crdName)) || 
-					    strings.Contains(strings.ToLower(path), "crd")) {
+					if strings.Contains(path, "custom-resources") &&
+						(strings.Contains(strings.ToLower(path), strings.ToLower(crdName)) ||
+							strings.Contains(strings.ToLower(path), "crd")) {
 						return path, data, true
 					}
 				}
 			}
 		}
-		
+
 	case "container-runtime":
 		// Container runtime analyzers - look for node information
 		if data, exists := bundle.Files["cluster-resources/nodes.json"]; exists {
 			return "cluster-resources/nodes.json", data, true
 		}
-		
+
 	case "distribution":
 		// Distribution analyzers - primarily use node information
 		if data, exists := bundle.Files["cluster-resources/nodes.json"]; exists {
@@ -746,103 +746,103 @@ func (a *OllamaAgent) autoDetectFileForAnalyzer(bundle *analyzer.SupportBundle,
 		if data, exists := bundle.Files["cluster-info/cluster_version.json"]; exists {
 			return "cluster-info/cluster_version.json", data, true
 		}
-		
+
 	case "storage-class":
 		// Storage class analyzers - look for storage class resources
 		for path, data := range bundle.Files {
 			if strings.Contains(path, "storage") && strings.HasSuffix(path, ".json") {
 				return path, data, true
 			}
 		}
-		
+
 	case "ingress":
 		// Ingress analyzers - look for ingress resources
 		for path, data := range bundle.Files {
 			if strings.Contains(path, "ingress") && strings.HasSuffix(path, ".json") {
 				return path, data, true
 			}
 		}
-		
+
 	case "http":
 		// HTTP analyzers can work with any network-related data
 		for path, data := range bundle.Files {
 			if strings.Contains(path, "services") || strings.Contains(path, "ingress") {
 				return path, data, true
 			}
 		}
-		
+
 	case "job-status":
 		// Job analyzers - look for job resources
 		for path, data := range bundle.Files {
 			if strings.Contains(path, "jobs") && strings.HasSuffix(path, ".json") {
 				return path, data, true
 			}
 		}
-		
+
 	case "statefulset-status":
 		// StatefulSet analyzers
 		for path, data := range bundle.Files {
 			if strings.Contains(path, "statefulsets") && strings.HasSuffix(path, ".json") {
 				return path, data, true
 			}
 		}
-		
+
 	case "replicaset-status":
 		// ReplicaSet analyzers
 		for path, data := range bundle.Files {
 			if strings.Contains(path, "replicasets") && strings.HasSuffix(path, ".json") {
 				return path, data, true
 			}
 		}
-		
+
 	case "cluster-pod-statuses":
 		// Pod status analyzers
 		for path, data := range bundle.Files {
 			if strings.Contains(path, "pods") && strings.HasSuffix(path, ".json") {
 				return path, data, true
 			}
 		}
-		
+
 	case "image-pull-secret":
 		// Image pull secret analyzers
 		for path, data := range bundle.Files {
 			if strings.Contains(path, "secrets") && strings.HasSuffix(path, ".json") {
 				return path, data, true
 			}
 		}
-		
+
 	case "yaml-compare", "json-compare":
 		// Comparison analyzers - can work with any structured data
 		for path, data := range bundle.Files {
 			if strings.HasSuffix(path, ".json") || strings.HasSuffix(path, ".yaml") {
 				return path, data, true
 			}
 		}
-		
+
 	case "certificates":
 		// Certificate analyzers
 		for path, data := range bundle.Files {
 			if strings.Contains(path, "cert") || strings.Contains(path, "tls") {
 				return path, data, true
 			}
 		}
-		
+
 	case "velero", "longhorn", "ceph-status":
 		// Storage system analyzers
 		for path, data := range bundle.Files {
 			if strings.Contains(strings.ToLower(path), spec.Name) {
 				return path, data, true
 			}
 		}
-		
+
 	case "sysctl", "goldpinger", "weave-report", "registry-images":
 		// Infrastructure analyzers
 		for path, data := range bundle.Files {
 			if strings.Contains(strings.ToLower(path), strings.ToLower(spec.Name)) {
 				return path, data, true
 			}
 		}
-		
+
 	case "cluster-resource":
 		// Generic cluster resource analyzer - can work with any cluster data
 		if data, exists := bundle.Files["cluster-resources/nodes.json"]; exists {

pkg/analyze/ceph.go

@@ -249,9 +249,9 @@ func detailedCephMessage(outcomeMessage string, status CephStatus) string {
 	}
 
 	if status.OsdMap.OsdMap.Full {
-		msg = append(msg, fmt.Sprintf("OSD disk is full"))
+		msg = append(msg, "OSD disk is full")
 	} else if status.OsdMap.OsdMap.NearFull {
-		msg = append(msg, fmt.Sprintf("OSD disk is nearly full"))
+		msg = append(msg, "OSD disk is nearly full")
 	}
 
 	if status.PgMap.TotalBytes > 0 {

pkg/analyze/host_kernel_configs.go

@@ -77,7 +77,7 @@ func (a *AnalyzeHostKernelConfigs) analyzeSingleNode(content collectedContent, c
 	for _, config := range hostAnalyzer.SelectedConfigs {
 		matches := kConfigRegex.FindStringSubmatch(config)
 		// zero tolerance for invalid kernel config
-		if matches == nil || len(matches) < 3 {
+		if len(matches) < 3 {
 			return nil, errors.Errorf("invalid kernel config: %s", config)
 		}