Skip to content

feat(run-pod): allow image pull retries in run pod collector - #1811

Merged
diamonwiggins merged 2 commits into
mainfrom
diamonwiggins/run-pod-image-pull-timeout
Jul 25, 2025
Merged

feat(run-pod): allow image pull retries in run pod collector#1811
diamonwiggins merged 2 commits into
mainfrom
diamonwiggins/run-pod-image-pull-timeout

Conversation

@diamonwiggins

Copy link
Copy Markdown
Contributor

Description, Motivation and Context

This PR adds a new allowImagePullRetries field to the RunPod collector configuration to control how ImagePullBackOff errors are handled.

Problem: Currently, when a RunPod collector encounters a pod in ImagePullBackOff state, it immediately fails regardless of any configured timeout. This prevents users from handling scenarios where image pulls might eventually succeed (e.g., temporary registry issues, authentication delays, or slow networks).

Solution: Added an optional allowImagePullRetries boolean field that allows ImagePullBackOff conditions to respect the configured timeout instead of failing immediately.

Behavior:

  • When allowImagePullRetries: false (default): Maintains existing behavior - fails immediately on ImagePullBackOff
  • When allowImagePullRetries: true: Waits for the configured timeout, allowing image pull retries to potentially succeed

Usage Example:

- runPod:
    timeout: "5m"
    allowImagePullRetries: true
    podSpec:
      containers:
      - name: my-container
        image: my-private-image

Checklist

  • New and existing tests pass locally with introduced changes.
  • [] Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@diamonwiggins diamonwiggins added the type::feature New feature or request label Jul 24, 2025
@diamonwiggins
diamonwiggins requested a review from a team as a code owner July 24, 2025 23:01
emosbaugh
emosbaugh previously approved these changes Jul 24, 2025
Comment thread pkg/apis/troubleshoot/v1beta2/collector_shared.go Outdated
@diamonwiggins
diamonwiggins merged commit 2861425 into main Jul 25, 2025
21 checks passed
@diamonwiggins
diamonwiggins deleted the diamonwiggins/run-pod-image-pull-timeout branch July 25, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type::feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants