-
Notifications
You must be signed in to change notification settings - Fork 112
adding brew #1872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding brew #1872
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,11 +4,10 @@ on: | |
| push: | ||
| tags: | ||
| - 'v*' | ||
| - '!v*-*' # Exclude prerelease tags like v1.0.1-beta, v1.0.1-alpha, etc. | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: false # Don't cancel releases | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| goreleaser: | ||
|
|
@@ -34,14 +33,16 @@ jobs: | |
| version: "v1.x" # Binary version to install | ||
| args: release --clean --config deploy/.goreleaser.yaml | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GITHUB_TOKEN: ${{ secrets.HOMEBREW_GITHUB_TOKEN }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: GoReleaser Fails Without Default GitHub TokenThe
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yep, this is as designed |
||
|
|
||
| - name: Update new preflight version in krew-index | ||
| if: ${{ !contains(github.ref_name, '-') }} | ||
| uses: rajatjindal/krew-release-bot@v0.0.47 | ||
| with: | ||
| krew_template_file: deploy/krew/preflight.yaml | ||
|
|
||
| - name: Update new support-bundle version in krew-index | ||
| if: ${{ !contains(github.ref_name, '-') }} | ||
| uses: rajatjindal/krew-release-bot@v0.0.47 | ||
| with: | ||
| krew_template_file: deploy/krew/support-bundle.yaml | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,29 +48,6 @@ builds: | |
| flags: -tags netgo -tags containers_image_ostree_stub -tags exclude_graphdriver_devicemapper -tags exclude_graphdriver_btrfs -tags containers_image_openpgp -installsuffix netgo | ||
| binary: support-bundle | ||
| hooks: {} | ||
| - id: collect | ||
| goos: | ||
| - linux | ||
| - darwin | ||
| goarch: | ||
| - amd64 | ||
| - arm | ||
| - arm64 | ||
| - riscv64 | ||
| ignore: | ||
| - goos: windows | ||
| goarch: arm | ||
| env: | ||
| - CGO_ENABLED=0 | ||
| main: cmd/collect/main.go | ||
| ldflags: -s -w | ||
| -X github.com/replicatedhq/troubleshoot/pkg/version.version={{.Version}} | ||
| -X github.com/replicatedhq/troubleshoot/pkg/version.gitSHA={{.Commit}} | ||
| -X github.com/replicatedhq/troubleshoot/pkg/version.buildTime={{.Date}} | ||
| -extldflags "-static" | ||
| flags: -tags netgo -tags containers_image_ostree_stub -tags exclude_graphdriver_devicemapper -tags exclude_graphdriver_btrfs -tags containers_image_openpgp -installsuffix netgo | ||
| binary: collect | ||
| hooks: {} | ||
| archives: | ||
| - id: preflight | ||
| builds: | ||
|
|
@@ -112,26 +89,6 @@ archives: | |
| - src: 'sbom/assets/*' | ||
| dst: . | ||
| strip_parent: true # this is needed to make up for the way unzips work in krew v0.4.1 | ||
| - id: collect | ||
| builds: | ||
| - collect | ||
| format: tar.gz | ||
| format_overrides: | ||
| - goos: windows | ||
| format: zip | ||
| name_template: 'collect_{{ .Os }}_{{ .Arch }}' | ||
| files: | ||
| - licence* | ||
| - LICENCE* | ||
| - license* | ||
| - LICENSE* | ||
| - readme* | ||
| - README* | ||
| - changelog* | ||
| - CHANGELOG* | ||
| - src: 'sbom/assets/*' | ||
| dst: . | ||
| strip_parent: true # this is needed to make up for the way unzips work in krew v0.4.1 | ||
| dockers: | ||
| - dockerfile: ./deploy/Dockerfile.troubleshoot | ||
| image_templates: | ||
|
|
@@ -142,7 +99,6 @@ dockers: | |
| ids: | ||
| - support-bundle | ||
| - preflight | ||
| - collect | ||
| - dockerfile: ./deploy/Dockerfile.troubleshoot | ||
| image_templates: | ||
| - "replicated/preflight:latest" | ||
|
|
@@ -152,4 +108,35 @@ dockers: | |
| ids: | ||
| - support-bundle | ||
| - preflight | ||
| - collect | ||
| universal_binaries: | ||
| - ids: | ||
| - preflight | ||
| replace: true | ||
| name_template: preflight | ||
| - ids: | ||
| - support-bundle | ||
| replace: true | ||
| name_template: support-bundle | ||
| brews: | ||
| - name: preflight | ||
| ids: | ||
| - preflight | ||
| homepage: https://docs.replicated.com/reference/preflight-overview/ | ||
| description: "A preflight checker and conformance test for Kubernetes clusters." | ||
| repository: | ||
| name: homebrew-replicated | ||
| owner: replicatedhq | ||
| branch: main | ||
| install: bin.install "preflight" | ||
| directory: HomebrewFormula | ||
| - name: support-bundle | ||
| ids: | ||
| - support-bundle | ||
| homepage: https://docs.replicated.com/reference/support-bundle-overview/ | ||
| description: "Collect and redact support bundles for Kubernetes clusters." | ||
| repository: | ||
| name: homebrew-replicated | ||
| owner: replicatedhq | ||
| branch: main | ||
| install: bin.install "support-bundle" | ||
| directory: HomebrewFormula | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug:
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Prerelease Tags Trigger Unintended Workflow
Removing the prerelease tag exclusion pattern causes the release workflow to trigger for prerelease tags. This results in GoReleaser publishing prerelease versions to Homebrew, which is likely unintended given that Krew updates are conditionally skipped for prereleases.
Additional Locations (1)
.github/workflows/release.yaml#L1-L6There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is intentional for now