fix(preflight): add tracing span and align error handling for host collector redaction - #2102
Merged
Merged
Conversation
…llector redaction Follow-up to #2101. Adds an OpenTelemetry span around host collector redaction and returns the unredacted collectResult on redaction failure, matching the behavior of remote host collectors and in-cluster support-bundle collectors.
|
Reviews (1): Last reviewed commit: "fix(preflight): add tracing span and ali..." | Re-trigger Greptile |
Member
Author
|
Good catch — fixed. |
|
Reviews (2): Last reviewed commit: "fix(preflight): assign collected data be..." | Re-trigger Greptile |
banjoh
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2101.
#2101 added redaction for local host preflight collectors, which was the only collection path that skipped redaction entirely. This PR addresses the review feedback that was not included before #2101 was merged:
The regression test added in #2101 ("TestCollectHostWithContext_RedactsSensitiveEnvValues") continues to verify that "run" host collector environment variables are redacted before being written to the bundle.