fix(runpod): strip pod spec before saving collected output - #2105
Merged
xavpaice merged 1 commit intoAug 11, 2026
Merged
Conversation
|
Reviews (1): Last reviewed commit: "fix(runpod): strip pod spec before savin..." | Re-trigger Greptile |
banjoh
approved these changes
Aug 11, 2026
xavpaice
deleted the
xavpaice/sc-139179/runpod-collector-exposes-sensitive-pod-spec
branch
August 11, 2026 21:13
|
Should this zero out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runPod collector was saving the full Kubernetes Pod object (including Spec) to the bundle. Because the PodSpec can contain env vars, commands, args, volumes, and imagePullSecrets, this leaked sensitive data into the collected output.
Changes:
Verification:
This also affects the deprecated run collector and goldpinger, both of which delegate to CollectRunPod. Goldpinger only reads pod.Name and pod.Status.ContainerStatuses, so it remains compatible.