feat(supportbundle): support secret/... redactor URIs - #2111
Merged
Conversation
|
Reviews (1): Last reviewed commit: "feat(supportbundle): support secret/... ..." | Re-trigger Greptile |
xavpaice
force-pushed
the
sc-139291-support-secret-redactor-uris
branch
from
August 19, 2026 03:37
30d859a to
b6923ce
Compare
|
Reviews (2): Last reviewed commit: "feat(supportbundle): support secret/... ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
secret/...URIs toLoadRedactorSpec, matching the existing support inLoadSupportBundleSpec.Changes
pkg/supportbundle/load.go:LoadRedactorSpecnow acceptssecret/<namespace>/<secret-name>[/<data-key>]URIs, with a default data key ofredactor-spec.pkg/supportbundle/load.go: added a package-levelloadFromSecrethook so the new code path can be unit-tested without requiring a cluster.pkg/supportbundle/load_test.go: addedTestLoadRedactorSpeccovering default and custom data keys, as well as validation for too few/too many path components.Motivation
KOTS stores rendered redactor specs in Kubernetes ConfigMaps today and passes
configmap/...URIs tokubectl support-bundle --redactors=.... To move those redactor specs to Secrets, the Troubleshoot library and CLI need to be able to load redactor specs fromsecret/...URIs.Related