Skip to content

feat(supportbundle): support secret/... redactor URIs - #2111

Merged
xavpaice merged 1 commit into
mainfrom
sc-139291-support-secret-redactor-uris
Aug 19, 2026
Merged

feat(supportbundle): support secret/... redactor URIs#2111
xavpaice merged 1 commit into
mainfrom
sc-139291-support-secret-redactor-uris

Conversation

@xavpaice

Copy link
Copy Markdown
Member

Summary

Adds support for secret/... URIs to LoadRedactorSpec, matching the existing support in LoadSupportBundleSpec.

Changes

  • pkg/supportbundle/load.go: LoadRedactorSpec now accepts secret/<namespace>/<secret-name>[/<data-key>] URIs, with a default data key of redactor-spec.
  • pkg/supportbundle/load.go: added a package-level loadFromSecret hook so the new code path can be unit-tested without requiring a cluster.
  • pkg/supportbundle/load_test.go: added TestLoadRedactorSpec covering default and custom data keys, as well as validation for too few/too many path components.

Motivation

KOTS stores rendered redactor specs in Kubernetes ConfigMaps today and passes configmap/... URIs to kubectl support-bundle --redactors=.... To move those redactor specs to Secrets, the Troubleshoot library and CLI need to be able to load redactor specs from secret/... URIs.

Related

@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown

Reviews (1): Last reviewed commit: "feat(supportbundle): support secret/... ..." | Re-trigger Greptile

@xavpaice
xavpaice force-pushed the sc-139291-support-secret-redactor-uris branch from 30d859a to b6923ce Compare August 19, 2026 03:37
@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown

Reviews (2): Last reviewed commit: "feat(supportbundle): support secret/... ..." | Re-trigger Greptile

@kriscoleman kriscoleman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@xavpaice
xavpaice merged commit 207cb90 into main Aug 19, 2026
29 checks passed
@xavpaice
xavpaice deleted the sc-139291-support-secret-redactor-uris branch August 19, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants