Skip to content

Commit 24ed924

Browse files
committed
fix(build): declare the extensions.xml namespace so Renovate tracks Nisse
Renovate parses `.mvn/extensions.xml` by default, but its maven manager rejects the file outright unless the root element carries a recognised EXTENSIONS namespace -- parseExtensions() returns null when `attr.xmlns` is not one of EXTENSIONS/1.0.0, 1.1.0 or 1.2.0, and the file is then skipped with no warning. Ours declared no xmlns at all, so Nisse would have sat at 0.9.5 indefinitely while every other dependency in the repo kept moving. Silent, and exactly the kind of rot the pin was supposed to avoid. Verified that Maven still resolves the version with the namespace present: tagging 9.9.9 and running `mvn help:evaluate -Dexpression=project.version` prints 9.9.9, unchanged. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
1 parent 3342ac7 commit 24ed924

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

‎.mvn/extensions.xml‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<extensions>
2+
<!-- The xmlns is load-bearing: Renovate's maven manager skips an extensions.xml
3+
without a recognised EXTENSIONS namespace, so without it Nisse is never
4+
updated. -->
5+
<extensions xmlns="http://maven.apache.org/EXTENSIONS/1.0.0"
6+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
7+
xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0 https://maven.apache.org/xsd/core-extensions-1.0.0.xsd">
38
<!-- Derives ${nisse.jgit.dynamicVersion} from git state, so the tag is the
49
only version. See RELEASING.md in reqstool/.github. -->
510
<extension>

0 commit comments

Comments
 (0)