Skip to content

Commit fe8cd2c

Browse files
Setup pkg.pr.new
1 parent 0465eee commit fe8cd2c

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

‎.github/workflows/ci.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ jobs:
3535
- name: Run tests
3636
run: npm test
3737

38+
- name: Publish preview package
39+
if: github.event_name == 'pull_request'
40+
run: npx pkg-pr-new publish --bin
41+
3842
- name: Pack (includes rescript build)
3943
run: npm pack
4044

‎src/NewProject.res‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,12 @@ let createNewProject = async () => {
117117
let useDefaultVersions = Option.isSome(commandLineArguments.templateName)
118118

119119
let projectName = switch commandLineArguments.projectName {
120-
| Some(projectName) if useDefaultVersions => projectName->validateProjectName->Option.getOrThrow
120+
| Some(projectName) if useDefaultVersions =>
121+
// Note this throws in the some case, which is why we cannot use Option.getOrThrow here.
122+
switch validateProjectName(projectName) {
123+
| Some(message) => JsError.throwWithMessage(message)
124+
| None => projectName
125+
}
121126

122127
| initialValue =>
123128
await P.text({

0 commit comments

Comments
 (0)