You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3182a36
Browse filesBrowse the repository at this point in the historyBrowse files
Enforce completion owners for public type aliases (#350)
## Summary
- validate that public `Foo.t` aliases have `@editor.completeFrom(Foo)`
on their internal backing types
- correct the existing completion owners and the
`Element.Impl.setAttributeNS` receiver type
- add compile-time coverage for recursive DOM aliases and inherited
element methods
## Why
Public modules expose internal record types through aliases. Several
backing types either had a stale completion owner or no annotation, so
editor completions could point at the internal module instead of the
public API. The feature validator now enforces this relationship for
future aliases while excluding intentional public-to-public `t` aliases.
This addresses the first follow-up item in #342.
## Validation
- `npm run build`
- `npm run check:features`
- `npm test`
- `npm run format:check`
- `git diff --check`
`${alias.backingModule}.${alias.backingType}, aliased by ${publicModule.moduleName}.t, must use @editor.completeFrom(${publicModule.moduleName}); received ${actualOwner??"no annotation"}.`,
This Streams API interface represents a readable stream of byte data. The WebApiFetch API offers a concrete instance of a ReadableStream through the body property of a Response object.
37
37
[See ReadableStream on MDN](https://developer.mozilla.org/docs/Web/API/ReadableStream)
38
38
*/
39
+
@editor.completeFrom(ReadableStream)
39
40
typereadableStream<'r> = {
40
41
/**
41
42
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/ReadableStream/locked)
@@ -70,7 +71,7 @@ type writableStreamDefaultController = private {
70
71
Provides information about files and allows JavaScript in a web page to access their content.
71
72
[See WebApiFile on MDN](https://developer.mozilla.org/docs/Web/API/File)
0 commit comments