You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Use native typed arrays in Web Audio and DOMMatrix bindings #389
src/geometry/DOMMatrix.res:47-L51 and the corresponding DOMMatrixReadOnly input/output methods: Float32Array conversions must use Float32Array.t.
Review Chromium probes rejected ordinary arrays for sampled analyser/copy/matrix methods, accepted native typed buffers, and confirmed typed return values. Filter signatures were reviewed against the platform contract, not separately browser-probed.
Acceptance criteria
Correct corresponding input and output types across all listed families, including both matrix modules.
Check related typed-array conversions for the same representation error.
Add browser tests using OfflineAudioContext and typed buffers, asserting output data/buffer behavior rather than merely construction.
Add typed DOMMatrix conversion round-trip tests.
Add compile tests rejecting ordinary arrays where native typed buffers are required.
Performance/behavior constraint
Do not insert implicit copies for output-buffer APIs: the native operation must write to the caller's supplied buffer. Keep the scope to representation correctness, not a Web Audio API redesign.
Coordination
Use the regression infrastructure in #383. Source fixes can be developed in parallel, but this issue should close with executed regression coverage, not only a successful compile.
Fixed by #399 and now on main through #397 at 844c32af. The listed audio and matrix APIs use native typed arrays without adding output-buffer copies. Browser regressions check channel contents and mutations to analyser/filter buffers. Matrix tests cover nonidentity conversions, and negative consumer fixtures reject plain arrays for analyser and matrix calls.
Main CI passed the browser, feature and negative-consumer checks. Closing as completed. This issue stayed open because #399 originally merged into a feature branch.
Activity
fix(webapi): correct browser API types and calls [Codex] (#399)
fix(webapi): correct browser API types and calls [Codex] (#399)
jderochervlk commentedon Nov 8, 2026
Fixed by #399 and now on main through #397 at 844c32af. The listed audio and matrix APIs use native typed arrays without adding output-buffer copies. Browser regressions check channel contents and mutations to analyser/filter buffers. Matrix tests cover nonidentity conversions, and negative consumer fixtures reject plain arrays for analyser and matrix calls.
Main CI passed the browser, feature and negative-consumer checks. Closing as completed. This issue stayed open because #399 originally merged into a feature branch.