Skip to content

fix(webapi): correct binding nullability and exception contracts [Codex] #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jderochervlk wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(webapi): correct binding nullability and exception contracts [Codex] #349

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a11e7cf
fix: audit Web API binding contracts
jderochervlk Aug 29, 2026
4a145db
fix: model HTMLElement hidden states
jderochervlk Aug 29, 2026
bbe9c53
fix: correct nullable Web API contracts
jderochervlk Sep 3, 2026
d05c2f2
fix: allow undefined hidden input
jderochervlk Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/animation/Animation.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ external cancel: t => unit = "cancel"
/**
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Animation/finish)
*/
@send
@throws(JsExn) @send
external finish: t => unit = "finish"

/**
Expand All @@ -99,7 +99,7 @@ external play: t => unit = "play"
/**
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Animation/pause)
*/
@send
@throws(JsExn) @send
external pause: t => unit = "pause"

/**
Expand Down Expand Up @@ -138,12 +138,12 @@ type iterationCompositeOperation =
type keyframeEffectOptions = {
...AnimationEffect.effectTiming,
mutable composite?: compositeOperation,
mutable pseudoElement?: Null.t<string>,
mutable pseudoElement?: Nullable.t<string>,
mutable iterationComposite?: iterationCompositeOperation,
}

type keyframeAnimationOptions = {
...keyframeEffectOptions,
mutable id?: string,
mutable timeline?: Null.t<animationTimeline>,
mutable timeline?: Nullable.t<animationTimeline>,
}
8 changes: 4 additions & 4 deletions src/animation/AnimationEffect.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ type getAnimationsOptions = {mutable subtree?: bool}

type computedEffectTiming = {
...effectTiming,
mutable progress?: Null.t<float>,
mutable currentIteration?: Null.t<float>,
mutable progress?: Nullable.t<float>,
mutable currentIteration?: Nullable.t<float>,
mutable startTime?: float,
mutable endTime?: float,
mutable activeDuration?: float,
mutable localTime?: Null.t<float>,
mutable localTime?: Nullable.t<float>,
}

type optionalEffectTiming = {
Expand Down Expand Up @@ -67,5 +67,5 @@ external getComputedTiming: t => computedEffectTiming = "getComputedTiming"
/**
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/AnimationEffect/updateTiming)
*/
@send
@throws(JsExn) @send
external updateTiming: (t, ~timing: optionalEffectTiming=?) => unit = "updateTiming"
2 changes: 1 addition & 1 deletion src/canvas/CanvasGradient.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Adds a color stop with the given color to the gradient at the given offset. 0.0
Throws an "IndexSizeError" DOMException if the offset is out of range. Throws a "SyntaxError" DOMException if the color cannot be parsed.
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasGradient/addColorStop)
*/
@send
@throws(JsExn) @send
external addColorStop: (CanvasTypes.canvasGradient, ~offset: float, ~color: string) => unit =
"addColorStop"

Expand Down
Loading