You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 1a49d91
Browse filesBrowse the repository at this point in the historyBrowse files
The Temporal bindings (#9044) need the `Temporal` global, which Node.js
22 lacks and Node.js 26 provides, so their tests and doc examples can
run in CI only on Node.js 26. `.nvmrc` now names 26. The build, coverage
and publish jobs read it through the setup-node action and pkg-pr-new
reads it directly; the changelog check now reads it too instead of
naming 22. The dev container and CONTRIBUTING.md move to 26 as well.
The installation tests keep Node.js 22, the oldest version the packages
support (`engines` `>=22`). build-compiler no longer runs the stdlib
tests on 22, so both installation jobs now run them there. They copy the
compiled tests in `tests/tests/src/stdlib` next to the installed
packages, install `@babel/code-frame`, which `Test.mjs` imports, at the
version `tests/tests` declares, and run `Stdlib_TestSuite.mjs` and
`Stdlib_TempTests.mjs` against the runtime from pkg.pr.new.
Node.js 25 stopped bundling corepack. The dev container's Node feature
enables corepack where Node.js bundles it and installs yarn with npm
otherwise, so `postCreate.sh` no longer runs `corepack enable`, which
would fail on 26.
Review: Do any tests behave differently on 26? The runtime doc examples
for `RegExp.escape` and `DataView.getFloat16`/`setFloat16`, which
`DocTest.res` skips below Node.js 24, now run in CI. They pass on
26.12.1, as does the rest of `make test`.
Review: Do the copied stdlib tests need anything else from the
repository? No. Apart from `@babel/code-frame` they import only each
other, `./Test.mjs`, `@rescript/runtime/lib/es6` and Node.js built-ins.
`Test.mjs` reads the `.res` source next to it only to print a failure,
and the copy includes the sources.
Review: Where do tests of APIs that Node.js 22 lacks go? Not into
`Stdlib_TestSuite` or `Stdlib_TempTests`, which now also run on 22.
Comments on the workflow step and in `Stdlib_TestSuite.res` say so. The
Temporal tests will need an entry point that only `scripts/test.js`
runs.
Review: Does the new step work on Windows? It copies with the same Git
Bash `cp` as the existing `installation_test` copy, and the tests find
the runtime through `node_modules`. `Test.mjs` takes its directory from
the pathname of `import.meta.url`, which starts with `/C:/` on Windows,
so a failing assertion there reports a missing `.res` file instead of a
code frame. The step still fails, just as the stdlib tests in the
Windows build-compiler job do today.
Review: Does anything else rely on corepack? No. Only `postCreate.sh`
ran it; the workflows never do.
Signed-off-by: mununki <woonki.moon@gmail.com>
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -32,7 +32,7 @@ algorithm and representation invariants belong beside their implementation.
32
32
33
33
> Most of our contributors are working on Apple machines, so all our instructions are currently macOS / Linux centric. Contributions for Windows development welcome!
34
34
35
-
-[Node.js](https://nodejs.org/)v22.x or newer
35
+
-[Node.js](https://nodejs.org/)v26.x or newer (the version in `.nvmrc`)
36
36
-[Yarn CLI](https://yarnpkg.com/getting-started/install) (can be installed with `corepack`, Homebrew, etc)
37
37
- C compiler toolchain (usually installed with `xcode` on Mac)
38
38
- Rust toolchain (required to build rewatch; follow the instructions at https://www.rust-lang.org/tools/install and install the version listed as `rust-version` in `rewatch/Cargo.toml`)
0 commit comments