Repository navigation
Commit 417ad95
Resolve an open's extension constructor only through its module
Why:
Codex review on #9085: an `open A` after a local extension `Value`
resolved the payload of an unqualified `Value(...)` to the local
constructor. Matching `A.Value` against the constructors also accepted
the bare local `Value` as a suffix, and the later declaration won. A
constructor named without a module is declared around the cursor, so
an open no longer brings it into scope.
Completion modified (extension payload after an open):
Example:
type attr = ..
module A = {
type attr += Value(bool)
}
type attr += Value(option<int>)
open A
let x: attr = Value()
Before (text): payload completion inside `Value()` completes
option<int>, the payload of the local Value
After (text): payload completion inside `Value()` completes
bool, the payload of A.Value: true, false
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Kr4cjoUi2f5VpMvE6wT9bo
Signed-off-by: Christoph Knittel <ck@cca.io>1 parent 30f0ed2 commit 417ad95
3 files changed
Lines changed: 42 additions & 1 deletion
File tree
- analysis/src
- tests/analysis_tests/tests/src
- expected
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
426 | 426 | | |
427 | 427 | | |
428 | 428 | | |
429 | | - | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
430 | 433 | | |
431 | 434 | | |
432 | 435 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1254 | 1254 | | |
1255 | 1255 | | |
1256 | 1256 | | |
| 1257 | + | |
| 1258 | + | |
| 1259 | + | |
| 1260 | + | |
| 1261 | + | |
| 1262 | + | |
| 1263 | + | |
| 1264 | + | |
| 1265 | + | |
| 1266 | + | |
| 1267 | + | |
| 1268 | + | |
| 1269 | + | |
| 1270 | + | |
| 1271 | + | |
| 1272 | + | |
| 1273 | + | |
| 1274 | + | |
| 1275 | + | |
| 1276 | + | |
| 1277 | + | |
| 1278 | + | |
| 1279 | + | |
| 1280 | + | |
| 1281 | + | |
| 1282 | + | |
| 1283 | + | |
| 1284 | + | |
| 1285 | + | |
0 commit comments