You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5689a30
Browse filesBrowse the repository at this point in the historyBrowse files
Fix Windows rewatch CI flakes from files opened without delete sharing (#9034)
* Open files with delete sharing on Windows
Unix.openfile opens files on Windows without FILE_SHARE_DELETE unless
asked, so while the watcher read lib/watch.lock (every 100 ms) or hashed
a source, other processes could not delete or rename it. Removing the
lock then failed with "Device or resource busy" and the watcher kept
running; Rust's File::open shares delete by default.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GtJW7McE7BZqNZGt5VULiK
Signed-off-by: Christoph Knittel <ck@cca.io>
* Retry removing watch.lock and stop a watcher that ignores it
A single failed rm left the watcher running into later tests, where the
runner later killed it as an orphan. Retry for five seconds, and kill the
watcher when it still does not exit so the failure stays in its test.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GtJW7McE7BZqNZGt5VULiK
Signed-off-by: Christoph Knittel <ck@cca.io>
* Diagnose Windows rewatch CI failures that leave no evidence
The retained-parse test now prints watch.log and calls.log when the edit
of B does not re-parse A. A watchdog in the parity step reports and stops
runaway rescript/bsc processes: four Windows runners lost contact with
GitHub during that step, past its timeout, without any log.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GtJW7McE7BZqNZGt5VULiK
Signed-off-by: Christoph Knittel <ck@cca.io>
* Serialize writes to the compiler call log
Parallel domains appended to REWATCH_COMPILER_CALL_LOG through separate
handles, and Windows emulates append as seek-then-write, so one domain's
line could overwrite another's. The retained-parse test then missed A's
parse line (and the initial build's implementation line for A) although A
was parsed: the Windows "flake" in that test was a lost log line.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GtJW7McE7BZqNZGt5VULiK
Signed-off-by: Christoph Knittel <ck@cca.io>
---------
Signed-off-by: Christoph Knittel <ck@cca.io>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
- On Windows, let other programs delete or rename files while the build system reads them, so stopping a watcher by removing `lib/watch.lock` no longer fails intermittently.
0 commit comments