Link signature help type definitions to their declaring file

Codex review on #9084: signature help built its Type definition link from
the caller's file, so for a type of an applied functor from another file
it pointed into the caller. It now takes the file from the type's
declaration, as hover does; the link function requires it, so no caller
can fall back to the wrong file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Kbf3gLMawVgtmiKy3TMBc3
Signed-off-by: Christoph Knittel <ck@cca.io>

Author: cknitt

analysis/src/hover.ml

@@ -149,14 +149,12 @@ let expand_types ~state ~file ~package ~supports_markdown_links typ =
           else (
             types_seen := String_set.add type_id !types_seen;
             true))
-      |> List.map (fun {decl; env; loc; path; uri} ->
+      |> List.map (fun {decl; loc; path; uri} ->
           let link_to_type_definition_str =
             if
               supports_markdown_links
               && not (is_inline_record_definition decl path)
-            then
-              Markdown.go_to_definition_text ~uri ~env
-                ~pos:loc.Warnings.loc_start ()
+            then Markdown.go_to_definition_text ~uri ~pos:loc.Warnings.loc_start
             else ""
           in
           Markdown.divider

analysis/src/markdown.ml

@@ -8,13 +8,8 @@ let make_goto_command link =
   Printf.sprintf "[%s](%s#L%d,%d)" link.label link.file (link.start_pos.line + 1)
     (link.start_pos.character + 1)
 
-let go_to_definition_text ?uri ~env ~pos () =
+let go_to_definition_text ~uri ~pos =
   let start_line, start_col = Pos.of_lexing pos in
-  let uri =
-    match uri with
-    | Some uri -> uri
-    | None -> env.Shared_types.Query_env.file.uri
-  in
   "\nGo to: "
   ^ make_goto_command
       {

analysis/src/signature_help.ml

@@ -9,10 +9,10 @@ let docs_for_label type_expr ~file ~state ~package ~supports_markdown_links =
   let type_names = types |> List.map (fun {Hover.name} -> name) in
   let type_definitions =
     types
-    |> List.map (fun {Hover.decl; name; env; loc; path} ->
+    |> List.map (fun {Hover.decl; name; loc; path; uri} ->
         let link_to_type_definition_str =
           if supports_markdown_links then
-            Markdown.go_to_definition_text ~env ~pos:loc.Warnings.loc_start ()
+            Markdown.go_to_definition_text ~uri ~pos:loc.Warnings.loc_start
           else ""
         in
         (* Since printing the whole name via its path can get quite long, and

tests/analysis_tests/tests/src/AppliedFunctorUse.res

@@ -8,3 +8,6 @@ let s = StrSet.add([], "a")
 
 let t: StrSet.t = []
 //            ^hov
+
+// let _ = StrSet.add(
+//                    ^she

tests/analysis_tests/tests/src/expected/AppliedFunctorUse.res.txt

@@ -15,3 +15,40 @@ Hover src/AppliedFunctorUse.res 8:14
   }
 }
 
+Signature help src/AppliedFunctorUse.res 11:22
+pos_cursor:[11:21] pos_no_white:[11:20] Found expr:[11:11->11:22]
+Pexp_apply ...[11:11->11:21] (...[14:0->11:22])
+pos_cursor:[11:21] pos_no_white:[11:20] Found expr:[11:11->11:21]
+Pexp_ident StrSet.add:[11:11->11:21]
+Completable: Cpath Value[StrSet, add]
+Package opens Stdlib.place holder Pervasives.JsxModules.place holder
+Resolved opens 1 Stdlib
+ContextPath Value[StrSet, add]
+Path StrSet.add
+arg_at_cursor: unlabelled<0>
+extracted params: 
+[t, string]
+{
+  "activeParameter": 0,
+  "activeSignature": 0,
+  "signatures": [
+    {
+      "activeParameter": 0,
+      "label": "(t, string) => array<string>",
+      "parameters": [
+        {
+          "documentation": {
+            "kind": "markdown",
+            "value": "```rescript\ntype t = array<string>\n```\nGo to: [Type definition](AppliedFunctor.res#L7,3)"
+          },
+          "label": [ 1, 2 ]
+        },
+        {
+          "documentation": { "kind": "markdown", "value": "" },
+          "label": [ 4, 10 ]
+        }
+      ]
+    }
+  ]
+}
+