Skip to content

Commit 61caa2f

Browse files
cknittclaude
andauthored
Leave the DCO check to the DCO app (#8860)
Shorten the sign-off rule to one line and tell reviewers not to check it. Claude-Session: https://claude.ai/code/session_01V8TEBFA2Kvqa5YFCXo6vpE Signed-off-by: Christoph Knittel <ck@cca.io> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 52783c8 commit 61caa2f

4 files changed

Lines changed: 6 additions & 37 deletions

File tree

‎AGENTS.md‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,9 @@ relevant guidance from each.
6767

6868
### Commit Standards
6969

70-
- Use DCO sign-off: `Signed-Off-By: Your Name <email>`
71-
- Put the sign-off in the final paragraph of the message, next to any other
72-
trailers such as `Co-Authored-By:`, with no blank line between them. Git only
73-
parses the last paragraph as trailers, so a sign-off separated by a blank
74-
line doesn't count. Check with
75-
`git log -1 --format=%B | git interpret-trailers --parse`.
70+
- Sign off every commit with `Signed-off-by: Your Name <email>` in the final
71+
trailer paragraph. The DCO app checks this on every PR, so reviewers don't
72+
need to.
7673
- Include appropriate tests with all changes
7774
- Build must pass before committing
7875

‎CONTRIBUTING.md‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -611,10 +611,8 @@ Then attempt to rebuild your project as you would normally.
611611

612612
## Contribution Licensing
613613

614-
Since ReScript is distributed under the terms of the [LGPL Version 3](LICENSE), contributions that you make are licensed under the same terms. In order for us to be able to accept your contributions, we will need explicit confirmation from you that you are able and willing to provide them under these terms, and the mechanism we use to do this is called a Developer's Certificate of Origin [DCO](DCO.md). This is very similar to the process used by the Linux(R) kernel, Samba, and many other major open source projects.
614+
ReScript is distributed under the [LGPL Version 3](LICENSE), and contributions are licensed under the same terms. To confirm that you can contribute under these terms, sign off every commit to certify the [Developer Certificate of Origin](https://developercertificate.org), as the Linux kernel and many other projects do:
615615

616-
To participate under these terms, all that you must do is include a line like the following as the last line of the commit message for each commit in your contribution:
616+
Signed-off-by: Random J. Developer <random@developer.example.org>
617617

618-
Signed-Off-By: Random J. Developer <random@developer.example.org>
619-
620-
You must use your real name (sorry, no pseudonyms, and no anonymous contributions).
618+
`git commit -s` adds this line. Use your real name. The DCO check on each PR fails if a commit lacks a sign-off; fix it with `git rebase --signoff HEAD~N`, where N is the number of commits in the PR, and force-push.

‎DCO.md‎

Lines changed: 0 additions & 25 deletions
This file was deleted.

‎context7.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
"COPYING",
2929
"COPYING.LESSER",
3030
"CREDITS.md",
31-
"DCO.md",
3231
"LICENSE",
3332
"LICENSE.MIT",
3433
"build-schema.json",

0 commit comments

Comments
 (0)