Skip to content

Commit 792d31d

Browse files
authored
Remove outdated Node.js version guards from docstring tests (#8421)
* Remove outdated Node.js version guards from docstring tests Node.js 20 has been dropped and the minimum is now v22, so the version guards for Node.js 20+ and 22+ features are no longer needed. * add coment and fix node version * add js file
1 parent 7b40918 commit 792d31d

2 files changed

Lines changed: 4 additions & 43 deletions

File tree

tests/docstring_tests/DocTest.res

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -15,32 +15,13 @@ let nodeVersion =
1515

1616
let ignoreRuntimeTests = [
1717
(
18-
// Ignore tests that require Node.js v20+
19-
20,
20-
["Stdlib_Array.toReversed", "Stdlib_Array.toSorted"],
21-
),
22-
(
23-
// Ignore tests that require Node.js v22+
24-
22,
25-
[
26-
"Stdlib_Promise.withResolvers",
27-
"Stdlib_Set.union",
28-
"Stdlib_Set.isSupersetOf",
29-
"Stdlib_Set.isSubsetOf",
30-
"Stdlib_Set.isDisjointFrom",
31-
"Stdlib_Set.intersection",
32-
"Stdlib_Set.symmetricDifference",
33-
"Stdlib_Set.difference",
34-
],
35-
),
36-
(
37-
// Ignore tests that require Node.js v24+
18+
// Ignore tests that require Node.js v24+ (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/escape#browser_compatibility)
3819
24,
3920
["Stdlib_RegExp.escape"],
4021
),
4122
(
42-
// Not available in Node.js yet
43-
1000,
23+
// Require Node.js v24+ (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView/setFloat16#browser_compatibility)
24+
24,
4425
["Stdlib_DataView.getFloat16", "Stdlib_DataView.setFloat16"],
4526
),
4627
]

tests/docstring_tests/DocTest.res.js

Lines changed: 1 addition & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)