You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 816a7e7
Browse filesBrowse the repository at this point in the historyBrowse files
Write missing-case examples beyond char literals as ints
A missing-case example in a char column took the kind of the first
pattern, so a value that no char literal can denote was printed as an
invalid one: a switch covering every char literal suggested
`'\u{110000}'`. Such values are now printed as ints.
Example (rescript):
let f = c =>
switch c {
| '\u{0}' .. '\u{10FFFF}' => 1
}
Before (text):
You forgot to handle a possible case here, for example:
| '\u{110000}'
After (text):
You forgot to handle a possible case here, for example:
| 1114112
Source: tests/build_tests/super_errors/fixtures/warning_8_char_range_beyond.res,
compiled with the parent commit and with this one.
Review: Codex found this for mixed ranges on #8894, where an example below 0
was printed as a char; the cause is here.
Area: typechecker tests
Output: unchanged
Errors: ERROR_VARIANTS.md warnings section lists warning_8_char_range_beyond.res
Tests: +tests/build_tests/super_errors/fixtures/warning_8_char_range_beyond.res
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JALXUyHhkDqzcB3WuW9Svo
Signed-off-by: Christoph Knittel <ck@cca.io>
0 commit comments