Repository navigation
Commit 8cc9caf
committed
Add accessors for type nodes
The type checker reads and writes the fields of `type_expr` directly in
about 1,000 places, which ties it to the boxed mutable record. Upstream
OCaml (4.14 and later) made `type_expr` abstract behind `get_desc`,
`get_level`, `get_id` and `Transient_expr`; this adds the same layer while
the record stays visible, so modules can be converted one at a time and
`type_expr` made abstract once none reads the fields.
`get_desc` returns the node's own descriptor and does not call `repr`, so
callers keep calling `repr` first and path compression stays where it is.
`get_desc`, `get_level` and the raw setters are field primitives, which
compile to the same loads and stores as field access, also in dune's dev
profile, which builds with `-opaque`.
Review: Does this change the representation or any output? No. The record
and its field order are unchanged; only the way code reaches the fields is
new.
Signed-off-by: Jono Prest <jjprest@gmail.com>1 parent c1927e6 commit 8cc9caf
2 files changed
Lines changed: 72 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
71 | 93 | | |
72 | 94 | | |
73 | | - | |
74 | | - | |
| 95 | + | |
| 96 | + | |
75 | 97 | | |
76 | 98 | | |
77 | 99 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
182 | 230 | | |
183 | 231 | | |
184 | 232 | | |
| |||
0 commit comments