You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit a531dc3
Browse filesBrowse the repository at this point in the historyBrowse files
Skip watch rebuilds for files whose content didn't change (#9305)
Why:
macOS can report one write twice, the second time after the 50 ms
drain window. The native watch loop re-read the file and rebuilt even
when nothing differed from its snapshot, so a parse error was printed
twice. This made the quiet-watch case of check_command_validation.sh
fail on macOS in about 4% of CI runs. The test's filter for repeated
reports had stopped working with the new report format in #9238.
Diagnostic modified (repeated content event in watch mode):
Example:
let value =
Before (diagnostic): rescript watch --quiet after one save on macOS
Syntax error!
<ROOT>/src/A.res:1:12-2:0
…
This let-binding misses an expression
Syntax error!
<ROOT>/src/A.res:1:12-2:0
…
This let-binding misses an expression
After (diagnostic):
Syntax error!
<ROOT>/src/A.res:1:12-2:0
…
This let-binding misses an expression
Review: Does a read error still rebuild? Yes. update_entries counts a
kept entry as a change, as before, so the build reports the problem.
Review: Does touching a file still rebuild? Yes. The entry holds the
modification time, as in the polling loop, so only an event for a file
that is exactly as the snapshot recorded it is skipped.
Claude-Session: https://claude.ai/code/session_01Kbf3gG8vKzkJGrU7AZ1CXQ
Signed-off-by: Christoph Knittel <ck@cca.io>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
0 commit comments