Skip to content

Commit b63a362

Browse files
cknittclaude
andcommitted
Skip the build system's integration suites in the OCaml 5.0 job
The job checks that the compiler builds with the oldest supported OCaml; its build system suites repeat the linux-x64 job's. A skip_rewatch_integration_tests matrix flag now selects the skipped steps instead of the OCaml version; the unit tests still run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gHAzsdStoCEpBgx2tS Signed-off-by: Christoph Knittel <ck@cca.io>
1 parent ed08a8c commit b63a362

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,14 @@ jobs:
6060
dune-profile: release
6161

6262
# Verify that the compiler still builds with the oldest OCaml version we support.
63-
# The build system's snapshot tests are skipped on this job; the
64-
# first linux-x64 job runs them. OCaml 5.0 does not build with GCC 15
65-
# (C23 by default), so this job stays on Ubuntu 24.04.
63+
# It runs only the build system's unit tests; the other build system
64+
# tests repeat the linux-x64 job's. OCaml 5.0 does not build with
65+
# GCC 15 (C23 by default), so this job stays on Ubuntu 24.04.
6666
- os: ubuntu-24.04
6767
ocaml_compiler: ocaml-variants.5.0.0+options,ocaml-option-static
6868
node-target: linux-x64
6969
dune-profile: static
70+
skip_rewatch_integration_tests: true
7071

7172
runs-on: ${{matrix.os}}
7273

@@ -224,7 +225,7 @@ jobs:
224225
shell: bash
225226

226227
- name: Run rewatch snapshot tests
227-
if: ${{ !contains(matrix.ocaml_compiler, '5.0.0') }}
228+
if: ${{ !matrix.skip_rewatch_integration_tests }}
228229
timeout-minutes: 20
229230
run: |
230231
. rewatch-ocaml/tests/process_watchdog.sh
@@ -248,7 +249,7 @@ jobs:
248249
shell: bash
249250

250251
- name: Run rewatch verbose output tests
251-
if: ${{ !contains(matrix.ocaml_compiler, '5.0.0') }}
252+
if: ${{ !matrix.skip_rewatch_integration_tests }}
252253
timeout-minutes: 10
253254
run: |
254255
bash rewatch-ocaml/tests/check_verbose_output.sh \
@@ -270,6 +271,7 @@ jobs:
270271
# process runs its executable as it starts, so it runs a copy. Its
271272
# output is shown once both are done.
272273
- name: Run rewatch focused integration and canonical tests
274+
if: ${{ !matrix.skip_rewatch_integration_tests }}
273275
timeout-minutes: 30
274276
run: |
275277
bin=packages/@rescript/${{ matrix.node-target }}/bin

0 commit comments

Comments
 (0)