Repository navigation
Commit faddac7
Suggest a coercion to the whole expected type (#9053)
Why:
The "compatible at runtime" hint checked the top-level types but
printed the innermost mismatch, so its suggestion didn't compile.
Diagnostic modified (coercion hint):
Example:
let consume = (_f: unit => Iterable.t<int>) => ()
let make: unit => Generator.t<int, unit, unit> = %raw(`function* () { yield 1 }`)
let () = consume(make)
Before (diagnostic):
- These types are compatible at runtime. You can use the coercion operator to convert to the expected type: (make :> iterable<int>)
After (diagnostic):
- These types are compatible at runtime. You can use the coercion operator to convert to the expected type: (make :> unit => Iterable.t<int>)
Fixes #9037
Claude-Session: https://claude.ai/code/session_01LZcKAmGvz6roKbTCq7or6f
Signed-off-by: Christoph Knittel <ck@cca.io>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>1 parent 1178cb3 commit faddac7
4 files changed
Lines changed: 29 additions & 0 deletions
File tree
- changes
- compiler/ml
- tests/build_tests/super_errors
- expected
- fixtures
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
772 | 772 | | |
773 | 773 | | |
774 | 774 | | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
775 | 780 | | |
776 | 781 | | |
777 | 782 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
0 commit comments