Remove code that recent master changes left unused

After rebasing onto master (Rust rewatch removal, flat lib/rescript),
master's new code still matched Lambda.Pis_undefined, which this branch
removes as never produced, and make dead-code reported:

- Js_exp_make.of_block ?e, and the test helpers' module_ ?interface and
  publish ?has_interface: never passed; removed.
- Cmi_format.input_cmi and Build_session.iter_package_plans: never used.
- Package_plan.t.source_files: never read; removed with its two writes.

The two Pis_undefined arms (Lambda, Lam_analysis) go.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Kbf3gLDo8mBJKpNE25WAwT
Signed-off-by: Christoph Knittel <ck@cca.io>

Author: cknitt

compiler/core/js_exp_make.ml

@@ -1770,7 +1770,7 @@ let bigint_mod ~checked (e0 : t) (e1 : t) =
 (* TODO -- alpha conversion
     remember to add parens..
 *)
-let of_block ?e block : t =
+let of_block block : t =
   let return_unit = false in
   (* This case is not hit that much*)
   call ~info:Js_call_info.ml_full_call
@@ -1782,18 +1782,7 @@ let of_block ?e block : t =
           {
             is_method = false;
             params = [];
-            body =
-              (match e with
-              | None -> block
-              | Some e ->
-                Ext_list.append block
-                  [
-                    {
-                      J.statement_desc = Return e;
-                      comment = None;
-                      source_loc = None;
-                    };
-                  ]);
+            body = block;
             env = Js_fun_env.make 0;
             return_unit;
             async = false;

compiler/core/js_exp_make.mli

@@ -307,7 +307,7 @@ val in_ : t -> t -> t
 
 val dummy_obj : Lambda.tag_info -> t
 
-val of_block : ?e:J.expression -> J.statement list -> t
+val of_block : J.statement list -> t
 (** convert a block to expresion by using IIFE *)
 
 val raw_js_code : Js_raw_info.code_info -> string -> t

compiler/core/lam_analysis.ml

@@ -174,8 +174,8 @@ let rec delay_safe ~assignable (lam : Lambda.t) : bool =
     | Pasrbigint | Pbigintcomp _ | Pbigintorder | Pbigintmin | Pbigintmax
     | Phash_mixint | Phash_mixstring | Phash_finalmix | Pis_null_undefined
     | Pjscomp _ | Pnull_to_opt | Pnull_undefined_to_opt | Pis_null
-    | Pis_undefined | Pis_not_none | Pval_from_option
-    | Pval_from_option_not_nest | Pis_poly_var_block ->
+    | Pis_not_none | Pval_from_option | Pval_from_option_not_nest
+    | Pis_poly_var_block ->
       true
     (* reads of the heap, and primitives with side effects *)
     | Pfield (_, (Fld_record _ | Fld_record_inline _ | Fld_record_extension _))

compiler/ml/cmi_format.ml

@@ -29,12 +29,6 @@ type cmi_infos = {
   cmi_flags: pers_flags list;
 }
 
-let input_cmi ic =
-  let name, sign = input_value ic in
-  let crcs = input_value ic in
-  let flags = input_value ic in
-  {cmi_name = name; cmi_sign = sign; cmi_crcs = crcs; cmi_flags = flags}
-
 (* Earlier compilers wrote OCaml-style magic numbers *)
 let legacy_magic_prefix = "Caml1999I"
 

compiler/ml/cmi_format.mli

@@ -25,7 +25,6 @@ type cmi_infos = {
 val create_cmi : ?check_exists:unit -> string -> cmi_infos -> Digest.t
 
 (* read the cmi information (the magic is supposed to have already been read) *)
-val input_cmi : in_channel -> cmi_infos
 
 (* read a cmi from a filename, checking the magic *)
 val read_cmi : string -> cmi_infos

compiler/ml/lambda.ml

@@ -740,10 +740,9 @@ let may_skip_operands (primitive : primitive) =
   | Pdict_has | Pawait | Pimport _ | Pinit_mod | Pupdate_mod | Phash
   | Phash_mixint | Phash_mixstring | Phash_finalmix | Pis_null_undefined
   | Pcreate_extension _ | Pjscomp _ | Pnull_to_opt | Pnull_undefined_to_opt
-  | Pis_null | Pis_undefined | Pis_not_none | Pval_from_option
-  | Pval_from_option_not_nest | Pis_poly_var_block | Praw_js_code _
-  | Pjs_fn_method | Ptagged_template _ | Ptemplate _ | Pdict_spread
-  | Parray_spread | Plist_spread ->
+  | Pis_null | Pis_not_none | Pval_from_option | Pval_from_option_not_nest
+  | Pis_poly_var_block | Praw_js_code _ | Pjs_fn_method | Ptagged_template _
+  | Ptemplate _ | Pdict_spread | Parray_spread | Plist_spread ->
     false
 
 (* Whether [primitive] on [args], the arguments of a call, evaluates them as

rewatch-ocaml/build_session.ml

@@ -106,7 +106,6 @@ let add_package_plan session package =
 
 let find_package_plan session root = Hashtbl.find_opt session.package_plans root
 
-let iter_package_plans session f = Hashtbl.iter f session.package_plans
 let package_plan_values session = Hashtbl.to_seq_values session.package_plans
 
 let add_source_reference session normalized_path source =

rewatch-ocaml/build_session.mli

@@ -42,7 +42,6 @@ val invalidate_graph_cycle : t -> unit
 val set_graph_cycle : t -> Module_graph.cycle_info option -> unit
 val add_package_plan : t -> Package_plan.t -> unit
 val find_package_plan : t -> string -> Package_plan.t option
-val iter_package_plans : t -> (string -> Package_plan.t -> unit) -> unit
 val package_plan_values : t -> Package_plan.t Seq.t
 val add_source_reference : t -> string -> source_reference -> unit
 val find_source_reference : t -> string -> source_reference option

rewatch-ocaml/package_graph.ml

@@ -145,7 +145,6 @@ let discover ~(root_config : Config.t) ~(workspace_config : Config.t) ~prod
                    dependencies);
             modules;
             source_mtimes;
-            source_files = discovery.inventory_files;
             present_source_files = discovery.present_files;
           }
       in

rewatch-ocaml/package_plan.ml

@@ -15,7 +15,6 @@ type t = {
   gentype_dependency_args: string list;
   modules: Source.module_ list;
   source_mtimes: (string, float) Hashtbl.t;
-  source_files: string list;
   present_source_files: string list;
 }