Repository navigation
Conversation
The publish job checks out rescript-lang.org inside this checkout. Yarn reads every .yarnrc.yml from its working directory up to the root, so the website's Yarn 4.13.0 also read ours, which since #8890 sets approvedGitRepositories, a setting 4.13.0 doesn't know. It stopped with a usage error in "Use Node.js for website", so 13.0.0-alpha.7 was published without its API docs and website playground update. The job now moves the website checkout to $RUNNER_TEMP and links it back. Yarn starts in the directory the link points to, so it reads only the website's .yarnrc.yml, and the later steps keep their paths. Review: Does pushing the API docs still authenticate? The deploy key is the core.sshCommand in the website's .git/config, which moves with it, and names the key by its absolute path in $RUNNER_TEMP. Only the HTTPS token is included by gitdir path, and the website's remote uses SSH. Review: How was this tested? Locally, with this repository's .yarnrc.yml and the website's Yarn 4.13.0 nested as in the job: before the step, `yarn config get cacheFolder` fails with the CI error; after it, the command succeeds both from a shell `cd` through the link and from a spawn with the link as its cwd, which is how setup-node runs it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Paul Tsnobiladzé <2479216+tsnobip@users.noreply.github.com>
ChangelogNo changelog entry. Semantic Diff1 commit · Full page Run the website's Yarn outside the compiler checkout when publishing36050db · tsnobip + Claude · Nov 05, 2026, 18:23 UTC The publish job checks out rescript-lang.org inside this checkout. Yarn reads every .yarnrc.yml from its working directory up to the root, so the website's Yarn 4.13.0 also read ours, which since #8890 sets approvedGitRepositories, a setting 4.13.0 doesn't know. It stopped with a usage error in "Use Node.js for website", so 13.0.0-alpha.7 was published without its API docs and website playground update. The job now moves the website checkout to $RUNNER_TEMP and links it back. Yarn starts in the directory the link points to, so it reads only the website's .yarnrc.yml, and the later steps keep their paths. Review
|
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-9240 |
|
Superseded by #9236, which fixes the same Publish failure on master by moving the compiler's |
The 13.0.0-alpha.7 publish run failed in "Use Node.js for website". The npm packages and the playground bundle went out, but the API docs, website build and website playground update did not.
Why it failed
The publish job checks out rescript-lang.org at
rescript-lang.org/, inside the compiler checkout. Yarn reads every.yarnrc.ymlfrom its working directory up to the root and merges them. So the website's Yarn 4.13.0 (itsyarnPathonv13) also read this repository's.yarnrc.yml. Since #8890 that file setsapprovedGitRepositories, a setting Yarn 4.13.0 doesn't know, and Yarn stops with:The previous publish run (September 16) predates #8890, which is why this didn't happen before. Dropping
cache: yarnwouldn't help, because the build step runsyarnin the same directory.The change
A new step right after the website checkout moves
rescript-lang.orgto$RUNNER_TEMPand links it back. Processes started through the link run in the real directory, outside the compiler checkout. So Yarn reads only the website's.yarnrc.yml, and every later step keeps itsrescript-lang.org/...paths (download-artifact, setup-node'scache-dependency-pathandnode-version-file,working-directory).This keeps the job working whenever this repository moves to a newer Yarn than the website. Bumping the website's Yarn would only fix it until the next such change.
For reviewers
actions/checkoutstores the deploy key ascore.sshCommandin the website's.git/config, which moves with the directory, and names the key by its absolute path in$RUNNER_TEMP. Only the HTTPS token is included through anincludeIf.gitdir:path, and the website's remote uses SSH..git/configthrough the link..yarnrc.yml, with the website's committed Yarn 4.13.0 nested as in the job. Before the step,yarn config get cacheFolderfails with the CI error. After it, the command succeeds both from a shellcdthrough the link (the build step) and from a spawn with the link as its cwd and a logicalPWD(setup-node). Linux resolves the link to the real directory the same way. No workflow linter is configured here, so the workflow wasn't run throughactionlint.Checklist
changes/README.md), or no release notes are needed and a maintainer should applychangelog:skip. (CI-only change, so this needschangelog:skip.)CONTRIBUTING.md).git commit -s).🤖 Generated with Claude Code