Repository navigation
Skip the build system's integration suites in the OCaml 5.0 job - #9280
Conversation
ChangelogNo changelog entry. Semantic Diff1 commit · Full page |
✅ Compiler benchmarksAllocated wordsIn total: 685,975,357 → 685,974,639 (±0.00%). None of the 261 benchmarks changed by 0.1% or more. InstructionsIn total: 9,675,830,989 → 9,675,830,989 (±0.00%). None of the 33 benchmarks changed by 0.1% or more. Output sizeIn total: 28,859,904 → 28,859,904 (±0.00%). None of the 13 benchmarks changed by 0.1% or more. Pull request 8ba10f2 compared with base e941d27 in this run. |
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-9280 |
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
8ba10f2 to
56ece01
Compare
ChangelogNo changelog entry. Semantic Diff1 commit · Full page ✏️ Skip the build system's integration suites in the OCaml 5.0 job68dc1cc · cknitt + Claude · Nov 09, 2026, 13:54 UTC · edited This job only needs to check that the compiler builds with the oldest OCaml version we support. The build system's integration tests already run in the linux-x64 job, so this job now skips them. A new matrix flag, skip_rewatch_integration_tests, turns them off. The unit tests still run. |
d1b010d to
b63a362
Compare
✅ Compiler benchmarksAllocated wordsIn total: 640,952,988 → 640,953,000 (±0.00%). Generated projects: 920,897,651 → 920,897,662 (±0.00%). None of the 265 benchmarks changed by 0.1% or more. InstructionsIn total: 9,209,714,214 → 9,209,714,214 (±0.00%). None of the 33 benchmarks changed by 0.1% or more. Output sizeIn total: 25,843,406 → 25,843,406 (±0.00%). None of the 13 benchmarks changed by 0.1% or more. Pull request 68dc1cc compared with base ed08a8c in this run. |
This job only needs to check that the compiler builds with the oldest OCaml version we support. The build system's integration tests already run in the linux-x64 job, so this job now skips them. A new matrix flag, skip_rewatch_integration_tests, turns them off. The unit tests still run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gHAzsdStoCEpBgx2tS Signed-off-by: Christoph Knittel <ck@cca.io>
b63a362 to
68dc1cc
Compare
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-9280 |
The OCaml 5.0.0 job only needs to check that the compiler builds with the oldest OCaml version we support. It already skipped some of the build system's integration tests, but still ran the focused and canonical suites, which the linux-x64 job runs too. Now it skips all of the build system's integration tests and runs only its unit tests, plus the compiler tests as before.
A new matrix flag,
skip_rewatch_integration_tests, turns these tests off. Before, each step checked the OCaml version instead.This only saves runner time, because this job is not on the critical path.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Kbf3gHAzsdStoCEpBgx2tS