Repository navigation
Remove ReasonReact and JSX v3 leftovers from analysis and genType - #9293
Conversation
Jsx_hacks kept ReasonReact's `fragment` out of the editor's index, a leftover from the ReasonReact JSX transform. ReScript's JSX doesn't produce it, so the module and its two guards go. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gKyiYMf54wPRxFdUWe Signed-off-by: Christoph Knittel <ck@cca.io>
Three heuristics in References.get_loc_item matched makeProps and createDOMElementVariadic, which only the JSX v3 transform generated. The heuristics that match by location alone stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gKyiYMf54wPRxFdUWe Signed-off-by: Christoph Knittel <ck@cca.io>
genType translated ReactDOMRe.domRef, ReactDOMRe.Ref.currentDomRef and ReasonReact.reactElement, and skipped ReasonReact.res when resolving modules. Current React bindings have none of these modules; the ReactDOM and React mappings stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gKyiYMf54wPRxFdUWe Signed-off-by: Christoph Knittel <ck@cca.io>
Changelog🏠 Internal
Semantic Diff3 commits · Full page Drop analysis's special case for ReasonReact.fragment0397e07 · cknitt + Claude · Nov 10, 2026, 20:37 UTC Jsx_hacks kept ReasonReact's Drop reference heuristics for JSX v3 names6ee9580 · cknitt + Claude · Nov 10, 2026, 20:37 UTC Three heuristics in References.get_loc_item matched makeProps and createDOMElementVariadic, which only the JSX v3 transform generated. The heuristics that match by location alone stay. Drop genType's mappings for ReasonReact and ReactDOMRe types0d9f2a4 · cknitt + Claude · Nov 10, 2026, 20:37 UTC genType translated ReactDOMRe.domRef, ReactDOMRe.Ref.currentDomRef and ReasonReact.reactElement, and skipped ReasonReact.res when resolving modules. Current React bindings have none of these modules; the ReactDOM and React mappings stay. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9293 +/- ##
==========================================
+ Coverage 81.97% 81.99% +0.01%
==========================================
Files 456 455 -1
Lines 65671 65653 -18
==========================================
- Hits 53836 53833 -3
+ Misses 11835 11820 -15
🚀 New features to boost your workflow:
|
✅ Compiler benchmarksAllocated wordsIn total: 640,771,238 → 640,771,183 (±0.00%). Generated projects: 920,861,847 → 920,863,020 (±0.00%). None of the 265 benchmarks changed by 0.1% or more. InstructionsIn total: 9,211,172,146 → 9,211,280,806 (±0.00%). None of the 33 benchmarks changed by 0.1% or more. Output sizeIn total: 25,843,198 → 25,842,868 (±0.00%). None of the 13 benchmarks changed by 0.1% or more. Pull request 0d9f2a4 compared with base 00e3f40 in this run. |
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-9293 |
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Removes leftovers of ReasonReact and the JSX v3 transform from editor analysis and genType, one commit each:
Jsx_hacks: kept ReasonReact'sfragmentout of the editor's index (a value inReasonReact.resand references toReasonReact.fragment). ReScript's JSX never produces it.References.get_loc_itemmatchedmakePropsandcreateDOMElementVariadic, which only the JSX v3 transform generated. The heuristics that match by location alone stay, since they don't depend on those names.ReactDOMRe.domRef,ReactDOMRe.Ref.currentDomRefandReasonReact.reactElementwere translated like theirReactDOM/Reactcounterparts, andReasonReact.reswas skipped when resolving modules. Current React bindings have none of these modules; theReactandReactDOMmappings stay. A doc comment's example moved fromReasonReact.reactClasstoReact.component.🤖 Generated with Claude Code
https://claude.ai/code/session_01Kbf3gKyiYMf54wPRxFdUWe