Repository navigation
Shorten the slowest CI legs: website build, format check, rewatch polling - #9302
Conversation
The website build ran on every pull request: the check for changed docs always found the copied .gitkeep and the website branch's older docs. An empty cache entry keyed on the website commit and the docs hash now records each build, so the ARM job skips about 3.5 minutes when the docs match an earlier build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gG8vKzkJGrU7AZ1CXQ Signed-off-by: Christoph Knittel <ck@cca.io>
The format check gives the same result on every platform but took 25 s on Windows and 18 s on macOS, both on the critical path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gG8vKzkJGrU7AZ1CXQ Signed-off-by: Christoph Knittel <ck@cca.io>
The canonical suite is the slowest part of each platform's rewatch step, and its waits polled once a second, so each of its ~150 waits took up to a second too long. Timeouts stay in seconds. Locally, the passing watch tests took 3.7 s instead of 6.9 s, 0.5 s instead of 4.1 s and so on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gG8vKzkJGrU7AZ1CXQ Signed-off-by: Christoph Knittel <ck@cca.io>
ChangelogNo changelog entry. Semantic Diff3 commits · Full page Build the website in CI only for API docs it hasn't built yetadc28e5 · cknitt + Claude · Nov 14, 2026, 09:16 UTC The website build ran on every pull request: the check for changed docs always found the copied .gitkeep and the website branch's older docs. An empty cache entry keyed on the website commit and the docs hash now records each build, so the ARM job skips about 3.5 minutes when the docs match an earlier build. Check formatting only on Linux in CIadc3052 · cknitt + Claude · Nov 14, 2026, 09:16 UTC The format check gives the same result on every platform but took 25 s on Windows and 18 s on macOS, both on the critical path. Poll every 0.1 s in the build system's canonical tests4f18f1e · cknitt + Claude · Nov 14, 2026, 09:16 UTC The canonical suite is the slowest part of each platform's rewatch step, and its waits polled once a second, so each of its ~150 waits took up to a second too long. Timeouts stay in seconds. Locally, the passing watch tests took 3.7 s instead of 6.9 s, 0.5 s instead of 4.1 s and so on. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9302 +/- ##
==========================================
- Coverage 82.06% 82.06% -0.01%
==========================================
Files 455 455
Lines 65399 65399
==========================================
- Hits 53672 53670 -2
- Misses 11727 11729 +2 🚀 New features to boost your workflow:
|
✅ Compiler benchmarksAllocated wordsIn total: 640,952,947 → 640,952,815 (±0.00%). Generated projects: 920,897,791 → 920,897,145 (±0.00%). None of the 265 benchmarks changed by 0.1% or more. InstructionsIn total: 9,209,713,740 → 9,209,713,740 (±0.00%). None of the 33 benchmarks changed by 0.1% or more. Output sizeIn total: 25,843,406 → 25,843,406 (±0.00%). None of the 13 benchmarks changed by 0.1% or more. Pull request 4f18f1e compared with base 1efa212 in this run. |
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-9302 |
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
A PR run takes about 12.5 minutes (median of 12 recent runs). The run waits for the slowest
build-compilerleg: ARM 557 s, Windows 550 s, macOS 459 s. This PR shortens all three..gitkeepshowed up as untracked, and the website'sv13branch has older docs than master. Now an empty cache entry, keyed on the website commit and the hash ofscripts/res/apiDocs, records each successful build. A PR whose docs match an earlier build skips the website checkout, Node setup and build. The first PR after the website branch moves still builds once.Together this should bring a PR run to about 10.5 minutes. The real numbers will show up in this PR's CI.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Kbf3gG8vKzkJGrU7AZ1CXQ