Skip to content

Commit 2131a3b

Browse files
authored
Add comments for multiple externals and remove unnecessary names (#497)
1 parent 4f5e069 commit 2131a3b

37 files changed

Lines changed: 120 additions & 103 deletions

‎reason-react-native/src/apis/ActionSheetIOS.md‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ external options:
2121
"";
2222
2323
[@bs.module "react-native"] [@bs.scope "ActionSheetIOS"]
24-
external showActionSheetWithOptions: (options, int => unit) => unit =
25-
"showActionSheetWithOptions";
24+
external showActionSheetWithOptions: (options, int => unit) => unit = "";
2625
2726
type shareOptions;
2827
[@bs.obj]
@@ -42,6 +41,6 @@ type error = {. "stack": option(string)};
4241
[@bs.module "react-native"] [@bs.scope "ActionSheetIOS"]
4342
external showShareActionSheetWithOptions:
4443
(shareOptions, error => unit, (bool, string) => unit) => unit =
45-
"showShareActionSheetWithOptions";
44+
"";
4645
4746
```

‎reason-react-native/src/apis/ActionSheetIOS.re‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ external options:
1414
"";
1515

1616
[@bs.module "react-native"] [@bs.scope "ActionSheetIOS"]
17-
external showActionSheetWithOptions: (options, int => unit) => unit =
18-
"showActionSheetWithOptions";
17+
external showActionSheetWithOptions: (options, int => unit) => unit = "";
1918

2019
type shareOptions;
2120
[@bs.obj]
@@ -35,4 +34,4 @@ type error = {. "stack": option(string)};
3534
[@bs.module "react-native"] [@bs.scope "ActionSheetIOS"]
3635
external showShareActionSheetWithOptions:
3736
(shareOptions, error => unit, (bool, string) => unit) => unit =
38-
"showShareActionSheetWithOptions";
37+
"";

‎reason-react-native/src/apis/Alert.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,6 @@ external alert:
4242
unit
4343
) =>
4444
unit =
45-
"alert";
45+
"";
4646
4747
```

‎reason-react-native/src/apis/Alert.re‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,4 @@ external alert:
3535
unit
3636
) =>
3737
unit =
38-
"alert";
38+
"";

‎reason-react-native/src/apis/AlertIOS.md‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,20 @@ external button:
1717
button =
1818
"";
1919
20+
// multiple externals
2021
[@bs.scope "AlertIOS"] [@bs.module "react-native"]
2122
external alert:
2223
(~title: string, ~message: string=?, ~buttons: array(button)=?, unit) =>
2324
unit =
24-
"alert";
25+
"";
2526
27+
// multiple externals
2628
[@bs.scope "AlertIOS"] [@bs.module "react-native"]
2729
external alertWithOKButton:
2830
(~title: string, ~message: string=?, ~callback: unit => unit=?, unit) => unit =
2931
"alert";
3032
33+
// multiple externals
3134
[@bs.scope "AlertIOS"] [@bs.module "react-native"]
3235
external prompt:
3336
(
@@ -62,8 +65,9 @@ external prompt:
6265
unit
6366
) =>
6467
unit =
65-
"prompt";
68+
"";
6669
70+
// multiple externals
6771
[@bs.scope "AlertIOS"] [@bs.module "react-native"]
6872
external promptWithOKButton:
6973
(

‎reason-react-native/src/apis/AlertIOS.re‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,20 @@ external button:
1010
button =
1111
"";
1212

13+
// multiple externals
1314
[@bs.scope "AlertIOS"] [@bs.module "react-native"]
1415
external alert:
1516
(~title: string, ~message: string=?, ~buttons: array(button)=?, unit) =>
1617
unit =
17-
"alert";
18+
"";
1819

20+
// multiple externals
1921
[@bs.scope "AlertIOS"] [@bs.module "react-native"]
2022
external alertWithOKButton:
2123
(~title: string, ~message: string=?, ~callback: unit => unit=?, unit) => unit =
2224
"alert";
2325

26+
// multiple externals
2427
[@bs.scope "AlertIOS"] [@bs.module "react-native"]
2528
external prompt:
2629
(
@@ -55,8 +58,9 @@ external prompt:
5558
unit
5659
) =>
5760
unit =
58-
"prompt";
61+
"";
5962

63+
// multiple externals
6064
[@bs.scope "AlertIOS"] [@bs.module "react-native"]
6165
external promptWithOKButton:
6266
(

‎reason-react-native/src/apis/AppRegistry.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ wip: true
77
```reason
88
[@bs.module "react-native"] [@bs.scope "AppRegistry"]
99
external registerComponent: (string, unit => React.component('a)) => unit =
10-
"registerComponent";
10+
"";
1111
1212
// react-native-web
1313
type app = {
@@ -17,6 +17,6 @@ type app = {
1717
};
1818
[@bs.module "react-native"] [@bs.scope "AppRegistry"]
1919
external getApplication: (string, {. "initialProps": 'a}) => app =
20-
"getApplication";
20+
"";
2121
2222
```
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[@bs.module "react-native"] [@bs.scope "AppRegistry"]
22
external registerComponent: (string, unit => React.component('a)) => unit =
3-
"registerComponent";
3+
"";
44

55
// react-native-web
66
type app = {
@@ -10,4 +10,4 @@ type app = {
1010
};
1111
[@bs.module "react-native"] [@bs.scope "AppRegistry"]
1212
external getApplication: (string, {. "initialProps": 'a}) => app =
13-
"getApplication";
13+
"";

‎reason-react-native/src/apis/AppState.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ let background: t;
1717
let inactive: t;
1818
1919
[@bs.scope "AppState"] [@bs.module "react-native"]
20-
external currentState: t = "currentState";
20+
external currentState: t = "";
2121
2222
[@bs.scope "AppState"] [@bs.module "react-native"]
2323
external addEventListener:

‎reason-react-native/src/apis/AppState.re‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ let background = "background";
1010
let inactive = "inactive";
1111

1212
[@bs.scope "AppState"] [@bs.module "react-native"]
13-
external currentState: t = "currentState";
13+
external currentState: t = "";
1414

1515
[@bs.scope "AppState"] [@bs.module "react-native"]
1616
external addEventListener:

0 commit comments

Comments
 (0)