Skip to content

Commit 236b5b0

Browse files
sgnycknitt
authored andcommitted
Define listener event type with variant, replace unnecessary names with empty strings (#489)
1 parent 81c542a commit 236b5b0

2 files changed

Lines changed: 16 additions & 15 deletions

File tree

‎reason-react-native/src/apis/Linking.md‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,23 +6,22 @@ wip: true
66

77
```reason
88
[@bs.scope "Linking"] [@bs.module "react-native"]
9-
external openURL: string => Js.Promise.t(unit) = "openURL";
9+
external openURL: string => Js.Promise.t(unit) = "";
1010
1111
[@bs.scope "Linking"] [@bs.module "react-native"]
12-
external canOpenURL: string => Js.Promise.t(bool) = "canOpenURL";
12+
external canOpenURL: string => Js.Promise.t(bool) = "";
1313
1414
[@bs.scope "Linking"] [@bs.module "react-native"]
15-
external getInitialURL: unit => Js.Promise.t(Js.Null.t(string)) =
16-
"getInitialURL";
17-
18-
let getInitialURL = () =>
19-
Js.Promise.(getInitialURL() |> then_(PromiseUtils.nullableToOption));
15+
external getInitialURL: unit => Js.Promise.t(Js.Null.t(string)) = "";
2016
2117
[@bs.scope "Linking"] [@bs.module "react-native"]
22-
external addEventListener: (string, {. "url": string} => unit) => unit = "";
18+
external addEventListener:
19+
([@bs.string] [ | `url], {. "url": string} => unit) => unit =
20+
"";
2321
2422
[@bs.scope "Linking"] [@bs.module "react-native"]
25-
external removeEventListener: (string, {. "url": string} => unit) => unit =
23+
external removeEventListener:
24+
([@bs.string] [ | `url], {. "url": string} => unit) => unit =
2625
"";
2726
2827
```
Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
11
[@bs.scope "Linking"] [@bs.module "react-native"]
2-
external openURL: string => Js.Promise.t(unit) = "openURL";
2+
external openURL: string => Js.Promise.t(unit) = "";
33

44
[@bs.scope "Linking"] [@bs.module "react-native"]
5-
external canOpenURL: string => Js.Promise.t(bool) = "canOpenURL";
5+
external canOpenURL: string => Js.Promise.t(bool) = "";
66

77
[@bs.scope "Linking"] [@bs.module "react-native"]
8-
external getInitialURL: unit => Js.Promise.t(Js.Null.t(string)) =
9-
"getInitialURL";
8+
external getInitialURL: unit => Js.Promise.t(Js.Null.t(string)) = "";
109

1110
[@bs.scope "Linking"] [@bs.module "react-native"]
12-
external addEventListener: (string, {. "url": string} => unit) => unit = "";
11+
external addEventListener:
12+
([@bs.string] [ | `url], {. "url": string} => unit) => unit =
13+
"";
1314

1415
[@bs.scope "Linking"] [@bs.module "react-native"]
15-
external removeEventListener: (string, {. "url": string} => unit) => unit =
16+
external removeEventListener:
17+
([@bs.string] [ | `url], {. "url": string} => unit) => unit =
1618
"";

0 commit comments

Comments
 (0)