Skip to content

Commit 415f6ad

Browse files
sgnyMoOx
authored andcommitted
Correct types for Gesture Responder props in components (#369)
* Correct types for Gesture Responder props in components * Add comments to associate props with the Gesture Responder system Closes #203
1 parent b90560b commit 415f6ad

13 files changed

Lines changed: 143 additions & 130 deletions

‎bs-react-native-next/src/components/ActivityIndicator.re‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,17 @@ external make:
5757
~onAccessibilityTap: unit => unit=?,
5858
~onLayout: Event.NativeLayoutEvent.t => unit=?,
5959
~onMagicTap: unit => unit=?,
60-
~onMoveShouldSetResponder: Event.NativeEvent.t => bool=?,
61-
~onMoveShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
62-
~onResponderGrant: Event.NativeEvent.t => unit=?,
63-
~onResponderMove: Event.NativeEvent.t => unit=?,
64-
~onResponderReject: Event.NativeEvent.t => unit=?,
65-
~onResponderRelease: Event.NativeEvent.t => unit=?,
66-
~onResponderTerminate: Event.NativeEvent.t => unit=?,
67-
~onResponderTerminationRequest: Event.NativeEvent.t => unit=?,
68-
~onStartShouldSetResponder: Event.NativeEvent.t => bool=?,
69-
~onStartShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
60+
// Gesture Responder props
61+
~onMoveShouldSetResponder: Event.t => bool=?,
62+
~onMoveShouldSetResponderCapture: Event.t => bool=?,
63+
~onResponderGrant: Event.t => unit=?,
64+
~onResponderMove: Event.t => unit=?,
65+
~onResponderReject: Event.t => unit=?,
66+
~onResponderRelease: Event.t => unit=?,
67+
~onResponderTerminate: Event.t => unit=?,
68+
~onResponderTerminationRequest: Event.t => unit=?,
69+
~onStartShouldSetResponder: Event.t => bool=?,
70+
~onStartShouldSetResponderCapture: Event.t => bool=?,
7071
~pointerEvents: [@bs.string] [
7172
| `auto
7273
| `none

‎bs-react-native-next/src/components/FlatList.re‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -151,16 +151,17 @@ external make:
151151
~onAccessibilityTap: unit => unit=?,
152152
~onLayout: Event.NativeLayoutEvent.t => unit=?,
153153
~onMagicTap: unit => unit=?,
154-
~onMoveShouldSetResponder: Event.NativeEvent.t => bool=?,
155-
~onMoveShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
156-
~onResponderGrant: Event.NativeEvent.t => unit=?,
157-
~onResponderMove: Event.NativeEvent.t => unit=?,
158-
~onResponderReject: Event.NativeEvent.t => unit=?,
159-
~onResponderRelease: Event.NativeEvent.t => unit=?,
160-
~onResponderTerminate: Event.NativeEvent.t => unit=?,
161-
~onResponderTerminationRequest: Event.NativeEvent.t => unit=?,
162-
~onStartShouldSetResponder: Event.NativeEvent.t => bool=?,
163-
~onStartShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
154+
// Gesture Responder props
155+
~onMoveShouldSetResponder: Event.t => bool=?,
156+
~onMoveShouldSetResponderCapture: Event.t => bool=?,
157+
~onResponderGrant: Event.t => unit=?,
158+
~onResponderMove: Event.t => unit=?,
159+
~onResponderReject: Event.t => unit=?,
160+
~onResponderRelease: Event.t => unit=?,
161+
~onResponderTerminate: Event.t => unit=?,
162+
~onResponderTerminationRequest: Event.t => unit=?,
163+
~onStartShouldSetResponder: Event.t => bool=?,
164+
~onStartShouldSetResponderCapture: Event.t => bool=?,
164165
~pointerEvents: [@bs.string] [
165166
| `auto
166167
| `none

‎bs-react-native-next/src/components/KeyboardAvoidingView.re‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,17 @@ external make:
5151
~onAccessibilityTap: unit => unit=?,
5252
~onLayout: Event.NativeLayoutEvent.t => unit=?,
5353
~onMagicTap: unit => unit=?,
54-
~onMoveShouldSetResponder: Event.NativeEvent.t => bool=?,
55-
~onMoveShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
56-
~onResponderGrant: Event.NativeEvent.t => unit=?,
57-
~onResponderMove: Event.NativeEvent.t => unit=?,
58-
~onResponderReject: Event.NativeEvent.t => unit=?,
59-
~onResponderRelease: Event.NativeEvent.t => unit=?,
60-
~onResponderTerminate: Event.NativeEvent.t => unit=?,
61-
~onResponderTerminationRequest: Event.NativeEvent.t => unit=?,
62-
~onStartShouldSetResponder: Event.NativeEvent.t => bool=?,
63-
~onStartShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
54+
// Gesture Responder props
55+
~onMoveShouldSetResponder: Event.t => bool=?,
56+
~onMoveShouldSetResponderCapture: Event.t => bool=?,
57+
~onResponderGrant: Event.t => unit=?,
58+
~onResponderMove: Event.t => unit=?,
59+
~onResponderReject: Event.t => unit=?,
60+
~onResponderRelease: Event.t => unit=?,
61+
~onResponderTerminate: Event.t => unit=?,
62+
~onResponderTerminationRequest: Event.t => unit=?,
63+
~onStartShouldSetResponder: Event.t => bool=?,
64+
~onStartShouldSetResponderCapture: Event.t => bool=?,
6465
~pointerEvents: [@bs.string] [
6566
| `auto
6667
| `none

‎bs-react-native-next/src/components/Picker.re‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,17 @@ external make:
5656
~onAccessibilityTap: unit => unit=?,
5757
~onLayout: Event.NativeLayoutEvent.t => unit=?,
5858
~onMagicTap: unit => unit=?,
59-
~onMoveShouldSetResponder: Event.NativeEvent.t => bool=?,
60-
~onMoveShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
61-
~onResponderGrant: Event.NativeEvent.t => unit=?,
62-
~onResponderMove: Event.NativeEvent.t => unit=?,
63-
~onResponderReject: Event.NativeEvent.t => unit=?,
64-
~onResponderRelease: Event.NativeEvent.t => unit=?,
65-
~onResponderTerminate: Event.NativeEvent.t => unit=?,
66-
~onResponderTerminationRequest: Event.NativeEvent.t => unit=?,
67-
~onStartShouldSetResponder: Event.NativeEvent.t => bool=?,
68-
~onStartShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
59+
// Gesture Responder props
60+
~onMoveShouldSetResponder: Event.t => bool=?,
61+
~onMoveShouldSetResponderCapture: Event.t => bool=?,
62+
~onResponderGrant: Event.t => unit=?,
63+
~onResponderMove: Event.t => unit=?,
64+
~onResponderReject: Event.t => unit=?,
65+
~onResponderRelease: Event.t => unit=?,
66+
~onResponderTerminate: Event.t => unit=?,
67+
~onResponderTerminationRequest: Event.t => unit=?,
68+
~onStartShouldSetResponder: Event.t => bool=?,
69+
~onStartShouldSetResponderCapture: Event.t => bool=?,
6970
~pointerEvents: [@bs.string] [
7071
| `auto
7172
| `none

‎bs-react-native-next/src/components/RefreshControl.re‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,17 @@ external make:
5656
~onAccessibilityTap: unit => unit=?,
5757
~onLayout: Event.NativeLayoutEvent.t => unit=?,
5858
~onMagicTap: unit => unit=?,
59-
~onMoveShouldSetResponder: Event.NativeEvent.t => bool=?,
60-
~onMoveShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
61-
~onResponderGrant: Event.NativeEvent.t => unit=?,
62-
~onResponderMove: Event.NativeEvent.t => unit=?,
63-
~onResponderReject: Event.NativeEvent.t => unit=?,
64-
~onResponderRelease: Event.NativeEvent.t => unit=?,
65-
~onResponderTerminate: Event.NativeEvent.t => unit=?,
66-
~onResponderTerminationRequest: Event.NativeEvent.t => unit=?,
67-
~onStartShouldSetResponder: Event.NativeEvent.t => bool=?,
68-
~onStartShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
59+
// Gesture Responder props
60+
~onMoveShouldSetResponder: Event.t => bool=?,
61+
~onMoveShouldSetResponderCapture: Event.t => bool=?,
62+
~onResponderGrant: Event.t => unit=?,
63+
~onResponderMove: Event.t => unit=?,
64+
~onResponderReject: Event.t => unit=?,
65+
~onResponderRelease: Event.t => unit=?,
66+
~onResponderTerminate: Event.t => unit=?,
67+
~onResponderTerminationRequest: Event.t => unit=?,
68+
~onStartShouldSetResponder: Event.t => bool=?,
69+
~onStartShouldSetResponderCapture: Event.t => bool=?,
6970
~pointerEvents: [@bs.string] [
7071
| `auto
7172
| `none

‎bs-react-native-next/src/components/SafeAreaView.re‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,17 @@ external make:
4646
~onAccessibilityTap: unit => unit=?,
4747
~onLayout: Event.NativeLayoutEvent.t => unit=?,
4848
~onMagicTap: unit => unit=?,
49-
~onMoveShouldSetResponder: Event.NativeEvent.t => bool=?,
50-
~onMoveShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
51-
~onResponderGrant: Event.NativeEvent.t => unit=?,
52-
~onResponderMove: Event.NativeEvent.t => unit=?,
53-
~onResponderReject: Event.NativeEvent.t => unit=?,
54-
~onResponderRelease: Event.NativeEvent.t => unit=?,
55-
~onResponderTerminate: Event.NativeEvent.t => unit=?,
56-
~onResponderTerminationRequest: Event.NativeEvent.t => unit=?,
57-
~onStartShouldSetResponder: Event.NativeEvent.t => bool=?,
58-
~onStartShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
49+
// Gesture Responder props
50+
~onMoveShouldSetResponder: Event.t => bool=?,
51+
~onMoveShouldSetResponderCapture: Event.t => bool=?,
52+
~onResponderGrant: Event.t => unit=?,
53+
~onResponderMove: Event.t => unit=?,
54+
~onResponderReject: Event.t => unit=?,
55+
~onResponderRelease: Event.t => unit=?,
56+
~onResponderTerminate: Event.t => unit=?,
57+
~onResponderTerminationRequest: Event.t => unit=?,
58+
~onStartShouldSetResponder: Event.t => bool=?,
59+
~onStartShouldSetResponderCapture: Event.t => bool=?,
5960
~pointerEvents: [@bs.string] [
6061
| `auto
6162
| `none

‎bs-react-native-next/src/components/ScrollView.re‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -102,16 +102,17 @@ external make:
102102
~onAccessibilityTap: unit => unit=?,
103103
~onLayout: Event.NativeLayoutEvent.t => unit=?,
104104
~onMagicTap: unit => unit=?,
105-
~onMoveShouldSetResponder: Event.NativeEvent.t => bool=?,
106-
~onMoveShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
107-
~onResponderGrant: Event.NativeEvent.t => unit=?,
108-
~onResponderMove: Event.NativeEvent.t => unit=?,
109-
~onResponderReject: Event.NativeEvent.t => unit=?,
110-
~onResponderRelease: Event.NativeEvent.t => unit=?,
111-
~onResponderTerminate: Event.NativeEvent.t => unit=?,
112-
~onResponderTerminationRequest: Event.NativeEvent.t => unit=?,
113-
~onStartShouldSetResponder: Event.NativeEvent.t => bool=?,
114-
~onStartShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
105+
// Gesture Responder props
106+
~onMoveShouldSetResponder: Event.t => bool=?,
107+
~onMoveShouldSetResponderCapture: Event.t => bool=?,
108+
~onResponderGrant: Event.t => unit=?,
109+
~onResponderMove: Event.t => unit=?,
110+
~onResponderReject: Event.t => unit=?,
111+
~onResponderRelease: Event.t => unit=?,
112+
~onResponderTerminate: Event.t => unit=?,
113+
~onResponderTerminationRequest: Event.t => unit=?,
114+
~onStartShouldSetResponder: Event.t => bool=?,
115+
~onStartShouldSetResponderCapture: Event.t => bool=?,
115116
~pointerEvents: [@bs.string] [
116117
| `auto
117118
| `none

‎bs-react-native-next/src/components/SectionList.re‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -153,16 +153,17 @@ external make:
153153
~onAccessibilityTap: unit => unit=?,
154154
~onLayout: Event.NativeLayoutEvent.t => unit=?,
155155
~onMagicTap: unit => unit=?,
156-
~onMoveShouldSetResponder: Event.NativeEvent.t => bool=?,
157-
~onMoveShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
158-
~onResponderGrant: Event.NativeEvent.t => unit=?,
159-
~onResponderMove: Event.NativeEvent.t => unit=?,
160-
~onResponderReject: Event.NativeEvent.t => unit=?,
161-
~onResponderRelease: Event.NativeEvent.t => unit=?,
162-
~onResponderTerminate: Event.NativeEvent.t => unit=?,
163-
~onResponderTerminationRequest: Event.NativeEvent.t => unit=?,
164-
~onStartShouldSetResponder: Event.NativeEvent.t => bool=?,
165-
~onStartShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
156+
// Gesture Responder props
157+
~onMoveShouldSetResponder: Event.t => bool=?,
158+
~onMoveShouldSetResponderCapture: Event.t => bool=?,
159+
~onResponderGrant: Event.t => unit=?,
160+
~onResponderMove: Event.t => unit=?,
161+
~onResponderReject: Event.t => unit=?,
162+
~onResponderRelease: Event.t => unit=?,
163+
~onResponderTerminate: Event.t => unit=?,
164+
~onResponderTerminationRequest: Event.t => unit=?,
165+
~onStartShouldSetResponder: Event.t => bool=?,
166+
~onStartShouldSetResponderCapture: Event.t => bool=?,
166167
~pointerEvents: [@bs.string] [
167168
| `auto
168169
| `none

‎bs-react-native-next/src/components/Switch.re‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,17 @@ external make:
6161
~onAccessibilityTap: unit => unit=?,
6262
~onLayout: Event.NativeLayoutEvent.t => unit=?,
6363
~onMagicTap: unit => unit=?,
64-
~onMoveShouldSetResponder: Event.NativeEvent.t => bool=?,
65-
~onMoveShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
66-
~onResponderGrant: Event.NativeEvent.t => unit=?,
67-
~onResponderMove: Event.NativeEvent.t => unit=?,
68-
~onResponderReject: Event.NativeEvent.t => unit=?,
69-
~onResponderRelease: Event.NativeEvent.t => unit=?,
70-
~onResponderTerminate: Event.NativeEvent.t => unit=?,
71-
~onResponderTerminationRequest: Event.NativeEvent.t => unit=?,
72-
~onStartShouldSetResponder: Event.NativeEvent.t => bool=?,
73-
~onStartShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
64+
// Gesture Responder props
65+
~onMoveShouldSetResponder: Event.t => bool=?,
66+
~onMoveShouldSetResponderCapture: Event.t => bool=?,
67+
~onResponderGrant: Event.t => unit=?,
68+
~onResponderMove: Event.t => unit=?,
69+
~onResponderReject: Event.t => unit=?,
70+
~onResponderRelease: Event.t => unit=?,
71+
~onResponderTerminate: Event.t => unit=?,
72+
~onResponderTerminationRequest: Event.t => unit=?,
73+
~onStartShouldSetResponder: Event.t => bool=?,
74+
~onStartShouldSetResponderCapture: Event.t => bool=?,
7475
~pointerEvents: [@bs.string] [
7576
| `auto
7677
| `none

‎bs-react-native-next/src/components/TextInput.re‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -245,16 +245,17 @@ external make:
245245
~onAccessibilityTap: unit => unit=?,
246246
~onLayout: Event.NativeLayoutEvent.t => unit=?,
247247
~onMagicTap: unit => unit=?,
248-
~onMoveShouldSetResponder: Event.NativeEvent.t => bool=?,
249-
~onMoveShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
250-
~onResponderGrant: Event.NativeEvent.t => unit=?,
251-
~onResponderMove: Event.NativeEvent.t => unit=?,
252-
~onResponderReject: Event.NativeEvent.t => unit=?,
253-
~onResponderRelease: Event.NativeEvent.t => unit=?,
254-
~onResponderTerminate: Event.NativeEvent.t => unit=?,
255-
~onResponderTerminationRequest: Event.NativeEvent.t => unit=?,
256-
~onStartShouldSetResponder: Event.NativeEvent.t => bool=?,
257-
~onStartShouldSetResponderCapture: Event.NativeEvent.t => bool=?,
248+
// Gesture Responder props
249+
~onMoveShouldSetResponder: Event.t => bool=?,
250+
~onMoveShouldSetResponderCapture: Event.t => bool=?,
251+
~onResponderGrant: Event.t => unit=?,
252+
~onResponderMove: Event.t => unit=?,
253+
~onResponderReject: Event.t => unit=?,
254+
~onResponderRelease: Event.t => unit=?,
255+
~onResponderTerminate: Event.t => unit=?,
256+
~onResponderTerminationRequest: Event.t => unit=?,
257+
~onStartShouldSetResponder: Event.t => bool=?,
258+
~onStartShouldSetResponderCapture: Event.t => bool=?,
258259
~pointerEvents: [@bs.string] [
259260
| `auto
260261
| `none

0 commit comments

Comments
 (0)